scap1784 / secureimplugin Goto Github PK

What steps will reproduce the problem?
1. Friend of my sends me a message while I am offline using SecureIM with
GPG and my public key.
2. I start miranda (or go to online mode), note: I am using metacontacts
3. Miranda crashes in SecureIM plugin

Details:
crashes in crypt_svcs.cpp on line 365 (len+=strlen(pm->message[i]);) while
calling strlen on uninitialized memory;

Suggestions:
crypt_svcs.cpp, rev 55, on lines 348, 358 (pm->message = new
LPSTR[part_all];) is allocation of array of string pointers which is not
initialized, adding following line could help:

memset( (void *) pm->message, 0, sizeof(LPSTR) * part_all );

but this did not fix the problem - after this change the message seems lost
but miranda does not crash (maybe I did not setup testing environment
correctly as I did not have time to inspect this further)...

Versions:
problem discovered on Miranda 0.7.8 unicode, secureim 1.0.10.9,
metacontacts 0.14.0.1
os: windows xp sp3

debugged on latest build: Miranda IM v0.8.0 Build #19 with current secureim
code from here (as of 19. aug 2008)

What steps will reproduce the problem?
1. Install Gpg4win 1.1.3 (GnuPG 1.4.9)
2. Miranda 0.0.8.5
3. Windows XP SP3
4. SecureIm 1.0.12.3
5. Set an ICQ-Contact to GPG-Mode. Right-Click in the contact list, select
"load GPG key". 

What is the expected output? What do you see instead?
The window has 2 columns: KeyID and UserID. UserID is all empty which is
not user friendly. The KeyID contains IDs. I looked up the appropriate key
for the ICQ contact in WinPT but nor the key-ID neither the fingerprint
matches any of the IDs in the SecureIM list. 

I find this only on jabber protocol.
=====================
What steps will reproduce the problem?
1. Start speak with person who has option "Always secured if possible" on.
2. Connect to jabber server from same JID, but with another resource using 
another client or miranda im with no secureim installed.
3. Write to person. And you get something like this:
ª andaril  20 апреля 2009 г.
ª 17:24 ntcn
ª 17:25 пашед?)
­
ª Креол  20 апреля 2009 г.
ª 17:25 ----DEINIT@HELL----
ª 17:25 ----Key3@hell----A07849EF--deleted manually--6DF2F00
­
ª andaril  20 апреля 2009 г.
ª 17:25 )))))))))))))))))))))))))))))
ª 17:25 Ыыыыыыыыыыы)))))
ª 17:25 :PPPP
­
ª Креол  20 апреля 2009 г.
ª 17:25 тест
ª 17:25 ----Key3@hell----78319--deleted manually--21CDF2F00
=====================
What is the expected output? What do you see instead?
How you see secureim don't see differenсe in jabber resources and try to 
send key whatever other client was secureim support or not.
=====================
What version of the product are you using? On what operating system?
¤ SecureIM.dll v.1.0.11.2 [20 Apr 2009 16:42:21] - SecureIM (2in1)
=====================
Best regards, Gennady andaril Gagin @ miranda planet team

What steps will reproduce the problem?
1. Chat using Yahoo account with another Yahoo contact.
2. Try to create secured connection (RSA/AES).

What is the expected output? What do you see instead?
With other protocols (that shows that there is Miranda on other side) 
secured connection created, with Yahoo protocol didn't.

What version of the product are you using? On what operating system?
Miranda v0.9.0 test build #1; cryptopp.dll v1.0.4.3; secureim.dll 
v1.0.12.3.

Please provide any additional information below.
On older versions of secureim.dll (for example v1.0.10.9) there wasn't his 
trouble.