Git Product home page Git Product logo

Comments (6)

HGRT846 avatar HGRT846 commented on June 26, 2024 1

@HGRT846 So far I can see the rooms are properly display, if you select the segment clean, when the vacuum start the room change slightly colour (meaning the indication on the card might be slightly off but the vacuum know where to go). The important think is the coordinates, does the vacuum move correctly to the go_to coordinates (on rand256 I use a room coordinate generation as the vacuum do not provide it in the json, I can use a similar approach also for the Hypfer vacuums, as it is more precise), the boxes (calculated rooms area) for the Hypfer can be sometime offset. Is the image at the original size? Additionally, the rooms colours of course can change on the map that generate the camera but not in the vacuum. What do you mean with can't change the room colours? Please check the docs for knowing how to change the colours of the rooms.

I tried to change the colors yesterday, but it didn`t work until I restarted HA today. I thought that options to configure colors were meant to IDs of the rooms (1 - 8, 9 - 16), and I have my IDs in valetudo from 17 to 22, so I thought it is a bug.

Anyway, thanks, I manually redacted coordinates and now everything works properly.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on June 26, 2024

@HGRT846 So far I can see the rooms are properly display, if you select the segment clean, when the vacuum start the room change slightly colour (meaning the indication on the card might be slightly off but the vacuum know where to go). The important think is the coordinates, does the vacuum move correctly to the go_to coordinates (on rand256 I use a room coordinate generation as the vacuum do not provide it in the json, I can use a similar approach also for the Hypfer vacuums, as it is more precise), the boxes (calculated rooms area) for the Hypfer can be sometime offset. Is the image at the original size?
Additionally, the rooms colours of course can change on the map that generate the camera but not in the vacuum. What do you mean with can't change the room colours? Please check the docs for knowing how to change the colours of the rooms.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on June 26, 2024

Will enhance the rooms coordinates calculation for the Hypfer vacuums in the next version planned for the second week of May, I'm sorry for the inconvenience but as temporally please consider to manually correct the segments data in the card (that by the way will be stored and not change afterwords). Of course if you need help with that I will be happy to assist you.

Screenshot 2024-04-30 at 08 50 41

The picture above show the difference on the rooms coordinates calculation.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on June 26, 2024

Changed the title for better tracking the issue. Also as mentioned, please, have a look to the colours management as per link above. Please also note that as I'm almost done with the 2024.05.0 the improvement you kindly proposed will be implemented on the release 2024.05.1. I just finished to re-flash the Hypfer firmware and work on it as soon I completed some tests pre-release for the 2024.05.0. Thanks in advance for your kind understanding, hope you will enjoy the camera and at your disposal for any required help ;)

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on June 26, 2024

@HGRT846 So far I can see the rooms are properly display, if you select the segment clean, when the vacuum start the room change slightly colour (meaning the indication on the card might be slightly off but the vacuum know where to go). The important think is the coordinates, does the vacuum move correctly to the go_to coordinates (on rand256 I use a room coordinate generation as the vacuum do not provide it in the json, I can use a similar approach also for the Hypfer vacuums, as it is more precise), the boxes (calculated rooms area) for the Hypfer can be sometime offset. Is the image at the original size? Additionally, the rooms colours of course can change on the map that generate the camera but not in the vacuum. What do you mean with can't change the room colours? Please check the docs for knowing how to change the colours of the rooms.

I tried to change the colors yesterday, but it didn`t work until I restarted HA today. I thought that options to configure colors were meant to IDs of the rooms (1 - 8, 9 - 16), and I have my IDs in valetudo from 17 to 22, so I thought it is a bug.

Anyway, thanks, I manually redacted coordinates and now everything works properly.

Well no the colours are not following the ids is the room number draw anyway you what? it will be a great Idea to implement a function that grab the rooms in use and show the ID number ;)

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on June 26, 2024

@HGRT846 I probably found the way to get the data more accurate for the rooms:

2024-05-01 16:54:47.250 INFO (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.valetudo.hypfer.image_handler] glossyhardtofindnarwhal: Overlapping Layers
2024-05-01 16:54:47.255 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2915, 2145, 3100, 2515)]
2024-05-01 16:54:47.289 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2385, 1760, 2970, 2805)]
2024-05-01 16:54:47.309 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2665, 2055, 2910, 2215)]
2024-05-01 16:54:47.442 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2400, 2215, 2800, 2800)]
2024-05-01 16:54:47.470 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2815, 2500, 2925, 2740)]
2024-05-01 16:54:47.492 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2800, 2165, 2890, 2355)]
2024-05-01 16:54:47.676 DEBUG (glossyhardtofindnarwhal_camera_0) [custom_components.valetudo_vacuum_camera.utils.drawable] [(2395, 1765, 2700, 2200)] 

As soon I'm done with it I look in the possibility to change the rooms colours menus with the rooms ID.
Will move this to the discussions and follow up as soon ;)

from valetudo_vacuum_camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.