sbailey / inspector Goto Github PK

I have a solution for displaying known lines, I will submit a PR soon.

NERSC's jupyter-dev is now using JupyterLab. Several things seem to be broken:

• Buttons used to be above the plot, now they are below.
• Prev/Next buttons internally advance the object (you can see this by pressing Next, then pressing one of the other buttons, then displaying the sp.visual_scan table. However, the display does not get updated.
• Emission/absorption lines no longer display.
• The widget that is supposed to display object metadata is broken (only displays "Hello There").

Filing a ticket to coordinate work. I have this working in a local branch (connected to navigation buttons too), but need to fiddle with conda packages at NERSC to get it working there before submitting a PR.

Add hooks for visual inspections, where users can record yes/no/maybe/flag and save their results in a format that can be merged with inspections from other users.

Filing a ticket to coordinate work. I have this working in a local branch but need to fiddle with NERSC conda packages to get it to work there before a pull request:

Add previous/next etc navigation buttons.

I'm a bit ambivalent about this, since I'd rather have a great tool that works only for DESI than a difficult to update tool that tries to work for everyone. But supporting at least DESI and SDSS would be nice. There are already enough DESI-specific pieces like resolution matrices and redrock outputs that we should proceed with caution. But consider this refactor at least and scope out the implications.

Cleanup code to bring it up to DESI standards for documentation, structure, etc.

Unit tests of a fundamentally interactive tool might be a bit of a stretch though.

After this is in better shape, we could move this to desihub to facilitate future contributions instead of sitting on it in my private repo.

I'm filing this ticket but I'm not claiming to be working on this yet...