Git Product home page Git Product logo

random-topic-generator's People

Contributors

sazdg avatar

Stargazers

avatar avatar

Watchers

avatar

Forkers

manuelvargas1251

random-topic-generator's Issues

For loop; repeated effort

At the end of the first loop, all your topics are already generated. So you should only loop once in the current implementation.

Random-Topic-Generator/randomapp.js

Lines 107 to 113 in 317be4d

for(var i = 0; i < 6; i++){
$scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
$scope.top2 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
$scope.top3 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
$scope.top4 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
$scope.top5 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
}

You could fix with something like this but it's a bit verbose. Only because your variables are what are hardcoded to the UI.
Let me know your thoughts

$scope.random = function(){
		for(var i = 0; i < 1; i++){
			console.log($scope.selected);
			switch($scope.selected){
			        case '1':
				        $scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
			                break;
                                case '2':
				        $scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
				        $scope.top2 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					break;
				case '3':
				        $scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top2 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top3 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					break;
				case '4':
				        $scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top2 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top3 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top4 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
                                       break;
				case '5':
				        $scope.top1 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top2 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top3 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
					$scope.top4 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
                                        $scope.top5 = $scope.subject[Math.floor(Math.random() * ($scope.len + 1))];
                                        break;
			}
		}
	}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.