saulis / angular2-iron-data-table Goto Github PK

From @DzmitryShylovich on August 9, 2016 11:12

I am, as a lot of Angular 2 developers, working more and more with Typescript. And, as you may know, Typescript needs typings for external libraries. So it would be great if you could add the typings within the npm module.

Should I move this to https://github.com/Saulis/angular2-iron-data-table ?

Copied from original issue: Saulis/iron-data-table#134

Trying to use with the final angular 2 release, but got typescript errors when building.

I also ran into issues using with the shady dom which I ended up fixing with:

dom.appendChild = function(el, node) {
if (node.nodeName === '#comment') {
el.appendChild(node);
} else {
Polymer.dom(el).appendChild(node);// Polymer.dom.flush();

//Guessing there's a better way to tell if something is a polymer element than checking for 'is'?
if( !el.is ) {
  Polymer.dom.flush();
}

}
};

Anyway, thanks for your work on this and the data table, they are really nice :)

This repo seems awesome but very difficult to implement!
I tried with angular-cli beta17 no success I can't get it working with angular -cli beta 17 a lot of errors, some enhancement in mind ? thanks

Currently only index.js file is included in npm module. It uses System.register... inside which makes it unusable with webpack because it throws Uncaught ReferenceError: System is not defined.

Would be nice to have index.ts file within npm module so webpack users can use iron table as well.

p.s Angular cli is migrating to webpack and systemjs will be dead soon.