sassembla / sctp-refimpl Goto Github PK

There is a memory leak in usrsctp/usrsctplib/user_socket.c in function 
usrsctp_conninput
The memory allocated here:
"if ((m = sctp_get_mbuf_for_msg(length, 1, M_NOWAIT, 0, MT_DATA)) == NULL)" 
(line 3200 in current rev)
is never released

I think a simple sctp_m_freem before the return would fix it, but I'm not very 
familiar with the code

I have a patch to work around http://llvm.org/bugs/show_bug.cgi?id=20177 and 
http://llvm.org/bugs/show_bug.cgi?id=20178 in order to fix building SCTP with 
clang-cl for Firefox.

What steps will reproduce the problem?
1.Add an alias IPv6 to an interface in some windows machine
2.Create socket for IPv6 and bind using the alias ip
3.Try to establish connection in client mode with some other SCTP server

What is the expected output? What do you see instead?
== The initial INIT packet should originate from the alias IPv6 used during 
bind, but the source IPv6 found to be the primary IPv6 of that interface and 
eventually it aborts the connection after receiving INIT_ACK from the peer node.

What version of the product are you using? On what operating system?
== I am using the revision 9168 (latest as of now) of the product in Windows 7 
ultimate 64-bit machine.

Please provide any additional information below.
== The library works fine for alias IPs when used for IPv4

I am studying SCTP and would like to write some software that uses it.  In the 
process of this project, I may find some things that need work, and I would 
like to help.

What steps will reproduce the problem?
1. bootstrap/configure/make KERN/usrsctp on mint linux (based on ubuntu 12.10)
2. Compilation fails in usrsctplib/user_socket.c
user_socket.c: In function 'usrsctp_dumppacket':
user_socket.c:3122:11: error: format '%d' expects argument of type 'int', but 
argument 8 has type '__suseconds_t' [-Werror=format]

tv_usec is suseconds_t which may be defined differently on different platforms. 
One way to deal with this is to print tv_usec as %jd and typecast argument to 
intmax_t. See attached patch.

sctp_userspace.c 144

struct sockaddr_in *addr;
...
addr = (struct sockaddr_in *)malloc(sizeof(struct sockaddr_in));
...
memcpy(&addr, &pAdapt->FirstUnicastAddress->Address.lpSockaddr, sizeof(struct 
sockaddr_in));

I think should be:
memcpy(addr, &pAdapt->FirstUnicastAddress->Address.lpSockaddr, sizeof(struct 
sockaddr_in));

--------------------------
Same with
#if defined(INET6)
        struct sockaddr_in6 *addr6;
#endif

The attached patches fix 3 build issues on a linux system with musl libc 
(http://musl-libc.org)

- musl is linux but does not have <sys/queue.h> by default. The first patch 
let's autoconf detect the presence of <sys/queue.h> and uses the fallback 
currently only used for Windows when not found

- musl does not have <sys/cdefs.h>. The header has mainly been used for macros 
for compatibility with pre-ANSI-C compilers. These macros (__BEGIN_DECLS, 
__END_DECLS and __P) are only used for FreeBSD. So make the include conditional 
on FreeBSD. It would also make sense to remove this cruft alltogether.

- musl follows POSIX and declares IPPORT_RESERVED in <netdb.h>. But <netdb.h> 
is never included in the source.

What steps will reproduce the problem?
1. Try to compile using attached buildiOS.sh that has iOS build setup

What is the expected output? What do you see instead?
Expect library to compile, instead get an error of missing include:

In file included from user_socket.c:35:
In file included from ./netinet/sctp_os.h:72:
./netinet/sctp_os_userspace.h:491:10: fatal error: 'netinet/ip_icmp.h' file not 
found
#include <netinet/ip_icmp.h>

What version of the product are you using? On what operating system?

Latest SVN checkout as of Feb 11 2015

Please provide any additional information below.

Diff file below fixes the problem. It disables include when not using inet and 
inet6.
Also people might find handy the build script for iOs

What steps will reproduce the problem?
1. Compile under windows
2. Run example echo_server and client

What is the expected output? What do you see instead?
Client is getting stuck on usrsctp_connect, no connection attempt appears to be 
sent and no error is returned from the call. 

What version of the product are you using? On what operating system?
Windows 7 64 bit

Please provide any additional information below.
compiled and tested on 2 different machines, the same problem occurs. 

What steps will reproduce the problem?
1. Compile usrscpt with INET and INET6
2. Link library in Xcode
3. Stack of some functions/callbacks will be corrupted due to INET and INET6 
not being defined in Xcode. For example sctp_sockstore will be inconsistent.

What is the expected output? What do you see instead?
I think it is expected from the library to define symbols like INET and INET6 
with library prefix, i.e. REFSCTP_INET REFSCTP_INET6 and include the symbol in 
the user header file. Otherwise one has no idea what flags were used to 
configure and build the library.

What version of the product are you using? On what operating system?
Revision 9168 on OSX

Please provide any additional information below.