sarven / unit-testing-tips Goto Github PK

This is a great resource, but I don't think your Data Fixtures section is right.

The information says that it's better to avoid shared state between tests and the "Bad" example given is using PHPUnit's setUp() method. But I don't think this example provides any shared state. The setUp() method should be called before each test. PHPUnit should also, as far as I'm aware, be running each test in a class in a new instance of the class.

From the manual...

The setUp() and tearDown() template methods are run once for each test method (and on fresh instances) of the test case class.

https://phpunit.readthedocs.io/en/9.5/fixtures.html#fixtures-examples-stacktest-php

I often see developers using mocks for entities to simplify their creation for testing.

While this is easy enough it creates a lot of coupling to the implementation details.

I would like to see a clear warning that mocks shouldn't be used especially for data classes like entities which have no side effects