sarenji / pokebattle-sim Goto Github PK

To prevent duplication of effort, it would be helpful if pokebattle-sim was able to return JSON learnsets given a Pokemon (forme?) and generation number.

If a Pokemon is disabled, but is unable to move for whatever reason (e.g. Paralysis, Sleep, Attract), does the disable counter still go down?

A Pokemon should store references to moves rather than strings of those moves. Strings are unreliable.

Sandstorm/Hail should not affect Pokemon using Dig and Dive.

Each Pokemon should only have one of each type of Attachment.

They should support:

• A maximum stack. If it goes over this stack, then attaching should fail. Implement this in the Attachments class.
• Attaching should return true/false depending on whether it failed or not. This'll give us more control in order to do certain things.

When a Pokemon faints, the owner can still select a move; if he does so, then the server acknowledges it for some reason.

Each Pokemon needs a variable that denotes the number of turns they have been in play since switch in. That is, every time it's switched in, this variable is reset to 0 turns.

Useful for implementation of Fake Out and Slow Start.

In all cases, you're acting against a Pokemon. Refactor it into pokemon.effectivenessOf(typeName).

Refactor modifyHP, modifyAttack etc into modifyStat(statName, ...; all implementations use the same method internals anyway. And it's easier to extend.

Some status moves should not be affected by type immunities.

Jigglypuff used Sing!
But it doesn't affect Haunter...

However, Thunder Wave has the correct behavior.