sarabveer / nanakshahi-js Goto Github PK

Hello Sarabveer:

While testing out the Nanakshahi library to cross-reference data for my own ruby library on some dates, I came across what appears to be a bug. Please have a look. Regards

const n = require('nanakshahi')

const date = new Date(2004, 3, 14)
console.log( n.getNanakshahiDate( date ) )

Output was Vaisakh 1, but should be Chet 1

Object
gregorianDate: Wed Apr 14 2004 00:00:00 GMT-0500 (Central Daylight Time)
englishDate: Object {month: 2, monthName: "Vaisakh", date: 1, year: 536, day: "Budhvaar", dayShort: "Budh"}
punjabiDate: Object {month: "੨", monthName: "ਵੈਸਾਖ", date: "੧", year: "੫੩੬", day: "ਬੁੱਧਵਾਰ", dayShort: "ਬੁੱਧ"}
leapYear: false

If Sanskranti is after 12AM and before Sunrise, Bikrami Sangrand should be on previous day.

Currently if sanskranti is after 12AM, Sangrand is current day, which doesn't follow the day rule being from Sunrise to Sunrise.

Many Sangrands do not match Punjab sangrands given in Jantri 500