saprykin / conan-plibsys Goto Github PK

Inclusion Request Review

This is a review for plibsys/0.0.4@saprykin/stable (saprykin/public-conan) inclusion request to conan-center.
This review follows the inclusion guidelines of third party libraries.

Package

plibsys/0.0.4@saprykin/stable
plibsys/0.0.3@saprykin/stable

Checks and Comments

Recipe quality

• Git public repository
• Recipe fields
• Linter
• Updated
• Clean
• test_package
• Raise errors on invalid configurations
• LICENSE of the recipe
• LICENSE of the library

CI Integration

• Provide at least one CI configuration (header only)
• (If not header only) CI configurations for Linux/MacOSX/Windows

Bintray Package Information

• Description
• Licenses
• Tags
• Maturity
• Website (if any)
• Issue tracker
• Version control

Additional comments

HI @saprykin,

Thank you so much for submiting you library to conan-center. We have reviewed the recipe and the generated packages and here are some things that will require minor improvements:

• We saw you have some tests in CPP but the library you are packaging is pure C, so there is no need to
  specify libcxx in the settings. Your conanfile.py should have this:

def configure(self):
    del self.settings.compiler.libcxx

• There are missing packages for apple-clang 9.1. Just add somethig like this to you .travis.yml file:

      - <<: *osx
        osx_image: xcode9.3
        env: CONAN_APPLE_CLANG_VERSIONS=9.1

• Finally we saw you are using the Bincrafters template for this repo. Are you planning to move it to the bincrafters organization? I so, it would be better to wait until it is moved to do the inclusion into conan-center