Git Product home page Git Product logo

cds-scp-api's People

Contributors

gregorwolf avatar raeijpe avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cds-scp-api's Issues

getConfigForTokenFetch is not defined - destination.js

When using 'csrfprotection:true' for connecting csrf protected APIs, it is failing with "getConfigForTokenFetch is not defined" ( Line 240 in destination.js)

I see a similar function in jcailan's repo

Can you please let me know how to proceed further on this issue?

Sample:

const service = await cdsapi.connect.to(""SCPDestination");
return await service.run({
url: "/Products",
method: "post",
headers: {
'content-type': 'application/json'
},
data: product,
csrfProtection: true
})

Successor?

Is there a successor / alternative or any further development on this repo?

Tests are failing

When I run npm test I get the following output:

  1) Class Destination
       Connection to Destination with No Authentication
         - check cdsapi.connect.to:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/gwolf/Documents/Projects/cap/cds-scp-api/test/destination.js)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)

  2) Class Destination
       Connection to Destination with No Authentication
         - check service.run:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/gwolf/Documents/Projects/cap/cds-scp-api/test/destination.js)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)

Is there anything that needs to be configured to make the tests running?

headers data passed in from client app gets removed in function getAuthorizationHeader

Issue found at line 35 in destination.js of function "getAuthorizationHeader". This line removes the entire "headers" data passed in from client app and replaced it with auth token retrieved from destination.

function getAuthorizationHeader(_config, cfDestinationInfo) {
return new Promise((resolve, reject) => {
var error;
var config = Object.assign({}, _config);
//config.headers = {} ***** DEFECT

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.