Git Product home page Git Product logo

Comments (12)

MN-public avatar MN-public commented on July 16, 2024

Hi Andreas, thanks for reporting the issue.
We need to see your complete project or at least know the minUI5 version set in your project because the significant part of the validation is specific to the UI5-version.

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

from ui5-language-assistant.

MN-public avatar MN-public commented on July 16, 2024

We could not reproduce your issue without the project.
We understand, that you cannot share the business project in the open source github.
Maybe you could create a dummy project showing the issue and share it with us? Or open the SNOW ticket to share your project securely with SAP?
BTW: What is the error text you see?

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

from ui5-language-assistant.

marufrasully avatar marufrasully commented on July 16, 2024

@AndreasTeufVoest

can you please share which version of UI5 Language Assistance you are using and what is the diagnostic message you get?

I would be happy for a Remote Session. Please suggest time and communication channel.

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

Seems this invitation didn't work out .. ;) ... where to send the invitation to?

from ui5-language-assistant.

marufrasully avatar marufrasully commented on July 16, 2024

@AndreasTeufVoest I just tried. Does it have session time out. you can send it here I try to rejoin or suggest a date with time.

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

from ui5-language-assistant.

AndreasTeufVoest avatar AndreasTeufVoest commented on July 16, 2024

<mvc:View controllerName="com.voestalpine.vakf.zfwmvakffastpick.controller.FastKommi"
xmlns:mvc="sap.ui.core.mvc" displayBlock="true"
xmlns="sap.m"
xmlns:l="sap.ui.layout"
xmlns:s="sap.m.semantic"
xmlns:f="sap.ui.layout.form">


<s:DetailPage xmlns:sap.m.semantic="sap.m.semantic" id="dp">

<s:content>

                <!--<OverflowToolbar id="otb1">
                    <ToolbarSpacer id="ts1"></ToolbarSpacer>
                    <ToggleButton id="tbUml" icon="sap-icon://BusinessSuiteInAppSymbols/icon-forklift" text="PVP / Umlagern" press="onPress" />
                    <ToggleButton id="tbKom" icon="sap-icon://home" text="Kommissionieren" press="onPress" />
                </OverflowToolbar>-->

                <f:Form xmlns:sap.ui.layout.form="sap.ui.layout.form" editable="true" class="editableForm" id="__form01">
                    <f:layout>
                        <f:ResponsiveGridLayout id="gridL1" labelSpanL="3" labelSpanM="3" labelSpanS="5" emptySpanL="3" emptySpanM="3" emptySpanS="0" columnsL="3" columnsM="" />
                    </f:layout>
                    <f:formContainers>
                        <sap.ui.layout.form:FormContainer id="container1">
                            <sap.ui.layout.form:formElements>
                                <sap.ui.layout.form:FormElement id="element1">
                                    <Input id="inpvbeln" editable="true" placeholder="Lieferschein" enabled="true" submit="onScanVbeln" valueLiveUpdate="true"/>
                                </sap.ui.layout.form:FormElement>


                                <sap.ui.layout.form:FormElement id="element3">
                                    <sap.ui.layout.form:fields>
                                        <Input id="inpStortype" editable="true" placeholder="Lagertyp" enabled="true" submit="onScanStorageBase" valueLiveUpdate="true"/>
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:fields>
                                        <Input id="inpStoreLoc" editable="true" placeholder="Lagerplatz" enabled="true" submit="onScanLgpla" valueLiveUpdate="true"/>
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Kom-Platz" id="lblKomplz" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element2">
                                    <Input id="inpetik" editable="true" placeholder="Etikett" enabled="true" submit="onScanLenumLoad" valueLiveUpdate="true"/>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element4">
                                    <sap.ui.layout.form:fields>
                                        <Input id="inpLagerpl" value="{Lgpla}" editable="false" placeholder="Lagerplatz" enabled="true" submit="" valueLiveUpdate="true"/>
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Lagerplatz" id="lblLagerpl" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element5">
                                    <sap.ui.layout.form:fields>
                                        <Input id="matnrdet" value="{Matnr}" editable="false" placeholder="Materialnr" enabled="true" submit="onScanLgtyp" valueLiveUpdate="true"/>
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Materialnr" id="lblMatnr" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element6">
                                    <sap.ui.layout.form:fields>
                                        <Input id="matbez" editable="false" value="{Maktx}" placeholder="Materialtext" enabled="true" submit="onScanLgtyp" valueLiveUpdate="true" />
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Bezeichnung" id="lblMattext" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element7">
                                    <sap.ui.layout.form:fields>
                                        <Input id="printer" editable="true" placeholder="Drucker" enabled="true" submit="" valueLiveUpdate="true" />
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Drucker" id="lblPrinterLoad" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element8">
                                    <sap.ui.layout.form:fields>
                                        <Input id="QuantMenge" value="{Menge}" type="Number" editable="true" placeholder="Einheit" enabled="true" submit="initCheckQuantity" valueLiveUpdate="true" />
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Menge" id="lblMenge" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element9">

                                    <sap.ui.layout.form:fields>
                                        <Input id="OffeneMenge" value="{MengeKom}" type="Number" editable="false" placeholder="Einheit" submit="takeOverQuant" valueLiveUpdate="true" />
                                    </sap.ui.layout.form:fields>

                                    <sap.ui.layout.form:label>
                                        <Label text="Offene Menge" id="lblOffMenge" />
                                    </sap.ui.layout.form:label>
                                    <sap.ui.layout.form:fields>
                                        <Button id="btntakeQuantity" text="Menge übernehmen" tooltip="Menge übernehmen" type="Accept" press="takeOverQuant" />
                                    </sap.ui.layout.form:fields>

                                </sap.ui.layout.form:FormElement>

                                <sap.ui.layout.form:FormElement id="element10">
                                    <sap.ui.layout.form:fields>
                                        <CheckBox id="chkbEtik" text="Etikett drucken" valueState="Information" selected="true"/>
                                    </sap.ui.layout.form:fields>
                                    <sap.ui.layout.form:label>
                                        <Label id="lblspace" text="" />
                                    </sap.ui.layout.form:label>
                                </sap.ui.layout.form:FormElement>
                            </sap.ui.layout.form:formElements>
                        </sap.ui.layout.form:FormContainer>
                    </f:formContainers>
                </f:Form>
            </s:content>
            <s:customFooterContent>
                <!--<Button id="btnBackLoad" tooltip="zurueck menu" press="onNavToChoiceLoad" icon="sap-icon://arrow-left" />-->

                <l:VerticalLayout id="footerLayout" width="100%">
                    <l:Grid id ="footerGrid" containerQuery="true" hSpacing="1" vSpacing="0" position="Center">

                        <Button id="btnpostMovement" tooltip="{i18n>btn_accept}" type="Accept" press="checkQuantity" icon="sap-icon://save" class="sapUiTinyMarginTopBottom" width="100%">
                            <layoutData>
                                <l:GridData id="_IDGenGridData1" span="XL2 L3 M6 S6" indentL="2" />
                            </layoutData>
                        </Button>
                        <Button id="btnabort" tooltip="{i18n>btn_abort}" type="Reject" press="onAbort" icon="sap-icon://decline" class="sapUiTinyMarginTopBottom" width="100%">
                            <layoutData>
                                <l:GridData id="_IDGenGridData2" span="XL2 L3 M6 S6" indentL="2" />
                            </layoutData>
                        </Button>
                    </l:Grid>


                </l:VerticalLayout>

            </s:customFooterContent>
            <s:messagesIndicator>
                <s:MessagesIndicator id="msgindi" press="onMessagesButtonPress" />
            </s:messagesIndicator>
        </s:DetailPage>
    </pages>
</App>

</mvc:View>

from ui5-language-assistant.

marufrasully avatar marufrasully commented on July 16, 2024

@AndreasTeufVoest
As per documentation the only allowed aggregation is 0..n of sap.m.Button so any another control should result in error. Therefore, error message is correct. If the app is working with UI5 version 1.71.57, it may not work in other UI5 versions. Please adapt your file content. Will below xml snippet be an option for you?

<s:customFooterContent>
    <Button
        id="btnpostMovement"
        tooltip="Accept"
        type="Accept"
        press="checkQuantity"
        icon="sap-icon://save"
        class="sapUiTinyMarginTopBottom"
    />
    <Button
        id="btnabort"
        tooltip="Abort"
        type="Reject"
        press="onAbort"
        icon="sap-icon://decline"
        class="sapUiTinyMarginTopBottom"
    />
</s:customFooterContent>

width="100%" is removed.
With above content, two buttons are rendered at right bottom corner as per SAP Fiori 1.0 design guidelines.

Screenshot 2023-11-24 at 11 43 43

If above is not an acceptable option, please change from sap.m.semantic.DetailPage to sap.m.Page instead. Sample code snippet

    <App id="app">
        <pages>
            <Page>
                <content>
                    
                </content>
                <footer>
                    <Bar>
                        <Button
                            id="btnpostMovement"
                            tooltip="Accept"
                            type="Accept"
                            press="checkQuantity"
                            icon="sap-icon://save"
                            class="sapUiTinyMarginTopBottom"
                        />
                        <Button
                            id="btnabort"
                            tooltip="Abort"
                            type="Reject"
                            press="onAbort"
                            icon="sap-icon://decline"
                            class="sapUiTinyMarginTopBottom"
                        />
                    </Bar>
                </footer>
            </Page>
        </pages>
    </App>

The UI looks like
Screenshot 2023-11-24 at 14 15 08

I hope this solves your issue. If not please open a ticket on UI5 component and close this issue.

Thanks and regards
MR

from ui5-language-assistant.

MN-public avatar MN-public commented on July 16, 2024

@AndreasTeufVoest
I think the bottom line here is that using of such structure is not supposed to work in runtime, the fact that it works now is a pure coincidence and can be changed at any time without any notice in a new UI5 version or even in the one you are using now (via some fix). So the error message is supposed to inform you that it should not be used in that context to prevent any issues with your app (current or future). To me this is a valid reason to keep it as an error.
Please consider other options to use the desired app behaviour as outlined above in #672 (comment)
I'm closing this ticket as answered

from ui5-language-assistant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.