The 'base' plugin sets up defaults for all gradle packaging tasks and those in turn break the packaging because they modify the filenames of the archives.

Currently tests failure on cloud tests execution (cloudTests and cloudWebTests) does not fail the build.

I had to configure it manually :

tasks.named<HybrisAntTask>("cloudTests") {
    antProperty("failbuildonerror", "yes")   
}

Could you please fail the build by default ?

When building smartedittools smartedittools.only.build.once=false, the discovery of existing extensions in the project folder slows a lot (from a few seconds to minutes), because it scans for extensioninfo.xml files in all the node_modules folders.

In

a task "removeUnusedExtensions" is declared and it uses a FileTreeWalker to remove files and directories. In my local tests, this process always exceeds the memory of the gradle process or it runs for more than 15 minutes, before I actually abort it. 👎

Wouldn't it be easier to compare the content of config/localextensions-generate.xml´ file, generated by ant extensionsxmlwith the files found using a simplefind . -type f -name extensioninfo.xml` from the "bin" directory?

This delta should show the extensioninfo.xml files from the extensions that need to be removed, therefore, removing their parent directory with rm -rf <PATH> should do the trick and should run very fast.

What do you think, @mpern ?

We are currently trying to implement the Gradle Plugin for our Setup and facing the Issue that the Variable "hybris.version" cannot be used.

Gradle Script:

plugins {
    id "sap.commerce.build" version "3.0.0"
    id "sap.commerce.build.ccv2" version "3.0.0"
}

hybris {
    // hybris version to use
    // is preconfigured with commerceSuiteVersion of the manifest
    version = "2005.5"
}

task printVersion {
  println "version: ${hybris.version}"
}

Result:
version: extension 'hybris' property 'version'

expected:
version: 2005.5

workaround
use ${hybris.version.get()}

something changed about file system access in Gradle 7.x

cleanPlatform is unbearably slow now

• setup clean test system without any AV scanners etc. interfering
• benchmark cleanPlatform
• optimize

As a developper I would like to :

• Use a unique tool to setup, build and run the platform : Gradle
• Minimise the number of tasks to execute manually to be able to build and run.
• Use the latest available SAP Commerce patch version in the Maven repository.

Currently we must run the bootstrapPlatform before running ybuild or any other task created by the
the Task Rule.

Suggestion : Add dependency to bootstrapPlatform for all tasks created by HybrisAntRule. Potentially this could be drive by inclusion/exclusion configuration properties with sensitive default values (include all, exclude none).

Hi,

the removeUnusedExtensions task seems to be not working with gradle >=6.7:
Cannot change default excludes during the build. They were changed from [**/#*#, **/%*%, **/*~, **/.#*, **/.DS_Store, **/._*, **/.bzr, **/.bzr/**, **/.bzrignore, **/.cvsignore, **/.git, **/.git/**, **/.gitattributes, **/.gitignore, **/.gitmodules, **/.hg, **/.hg/**, **/.hgignore, **/.hgsub, **/.hgsubstate, **/.hgtags, **/.svn, **/.svn/**, **/CVS, **/CVS/**, **/SCCS, **/SCCS/**, **/vssver.scc] to []. Configure default excludes in the settings script instead.

Here is the changelog for this:
https://docs.gradle.org/current/userguide/upgrading_version_6.html#changing_default_excludes_during_the_execution_phase

The sap.commerce.build fails to invoke ant-tasks when using the latest sap commerce version 2211.7.

The version 2211.6 uses the version number "version=2211.6" in bin/platform/build.number
The version 2211.7 uses "version=2211.FP1". The "FP1" gets converted to a number and fails the build.

error message for input string "FP1"

On windows, it looks like we need to escape the backslashes for the hybris.optional.config.dir
hybris.optional.config.dir=C:\\myproject\\config\\own-config

I am not sure if this is even the right place to ask, if not, please let me know, where i should instead ask :)

I want to download the SAP Commerce artifacts via CI so i can easier distribute them with my co workers. We are using a Package Registry tool for storing most of our artifacts. To reduce the overhead, we thought it is a good ides to use our CI infrastructure to download via CURL and store it in the Package registry.

Sadly this seems to be not working, i assume it is related to our infrastructure within GCP. But if i use the same docker image locally for downloading, i have no issues at all downloading. But if i use it with the CI system, i am always redirected to a page via AkamaiGHost and my first request is a Temporarly Moved request.

I thought i ask here based on https://github.com/SAP/commerce-gradle-plugin/blob/master/docs/FAQ.md#faq - as this was my main orientation for the tooling. Maybe somebody else already had this problem, and found a solution.

Thank you

There is an issue with ant tasks in camelCase that prevent them from being executed. Eg: startHybrisServer becomes starthybrisserver, which is not a registered task. The issue seems to be in HybrisAntRule.java. Is it required to lowercase the task name before executing it?

https://github.com/sap-commerce-tools/commerce-gradle-plugin/blob/4636d9a237b3eb9e649ae3bef14f91ab1ebf0166/src/main/java/mpern/sap/commerce/build/rules/HybrisAntRule.java#L25

Regards

If you the project uses a very minimal manifest (without storefrontAddons, properties or aspects) applying the plugin will fail with NPEs

Workaround (for now):

add empty arrays for any of the above keys

{
    "commerceSuiteVersion": "1811.3",
    "extensions": [
        ...
    ],
    "storefrontAddons": [],
    "properties": [],
    "aspects": []
}

I am trying to use your plugin to setup Commerce 2211 using Gradle 8.2.1 and Java 17

I noticed this failed

• What went wrong: Execution failed for task ':yclean'.
  Failed to notify task execution listener.
  'org.gradle.api.tasks.JavaExec mpern.sap.commerce.build.tasks.HybrisAntTask.setMain(java.lang.String)'

And that's due to the fact that Gradle is migrating many tasks over to Property<String>. Specifically getMainClass().set(string) should be used instead.

https://docs.gradle.org/8.2.1/javadoc/org/gradle/process/JavaExecSpec.html#setMain-java.lang.String-

More precisely, we're using SAP's Gradle plugin and extending it to support the functionality that we want for our proprietary plugin.

• new dependency
• help with configuration
• replace of extensions or change extension loading

• FileCollection.stopExecutionIfEmpty() not available anymore -> CloudServicesPackagingPlugin.java needs a different way to fail when the required files for the package aren't available

• Update GH Actions to latest versions
• Update Gradle
• Update Gradle Plugins
  • nice-to-have: Use Test Suite Plugin to define integrationTest, functionalTest
• Java 17 -> drop support for all Gradle versions < 7.6
• Update build script: use use kotlin script
• Split codebase into subprojects:
  • [ ] platform utils
  • test utils (replaces commonTest source set)
  • build plugin
  • ccv2 plugin
• remove ccv1 plugin

Hi,

It seems SAP has changed (again) the way of versioning hybris.

While for the manifest we need to set:
"commerceSuiteVersion": "1811",

On platform/build.number we get
version=18.11

This causes that every time we do a .gradlew bootstrapPlatform the plugin detects that the version have changed:
current version: 18.11; required version: 1811

This happens even if we configure hybris.version in our build.gradle, so the version on the manifest seems to have preference over the configuration. IMHO, this should be the other way around.

hybris {
    version = '18.11'
}

Regards

The plugin API needs to be upgraded to support current gradle releases.

This will remove support for all versions smaller than 5, IIRC

It would be really cool if we could pass ant properties via Command line, e.g. :

$ gradle -DantProperty.build.parallel=true -DantProperty.build.development.mode=true ybuild

and/or

$ gradle -DantProperties=build.parallel=true,build.development.mode=true ybuild # need to escape ',' in ant properties ;)

As of SAP Commerce 2005, Cloud Extension Pack have been replaced by Cloud Integration Extension Pack.

Currently the CCv2 plugin only supports Cloud Extension Pack and should also support Cloud Integration Extension Pack.

Looks like the gradles copyisn't very fast for large files.

Possible improvements:

• Use AntBuilder and run ant-based unzip
• Drop down to native?
  • Detect if unzip, p7za is available inPATH
  • run native command to unpack

https://github.com/sap-commerce-tools/commerce-gradle-plugin/blob/master/src/main/java/mpern/sap/commerce/build/HybrisPlugin.java#L73-L78

Hello, I really like your plugin and want to use it for a new project, but unfortunately in your IntExtPackValidator there are the new sap commerce version 2105 and the new int ext pack version 2108 missing. Can you please add them?
I tried to open a Pull Request, but I don't have permissions for this.

This is highlighted when configuring cloudTests and/ro cloudWebTests tasks when no test configuration is defined in the manifest :

tasks.named<HybrisAntTask>("cloudWebTests") {
    antProperty("failbuildonerror", "yes")   
}

$ ./gradlew cloudWebTests                                                                                

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/i303934/SAPDevelop/Projects/LaPoste/git/phoenix-commerce/core-customize/build.gradle.kts' line: 59

* What went wrong:
The task 'cloudWebTests' (org.gradle.api.DefaultTask) is not a subclass of the given type (mpern.sap.commerce.build.tasks.HybrisAntTask).

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

The hybris ant task throws the error java.lang.IllegalAccessError: class com.oopsconsultancy.xmltask.jdk15.XPathAnalyser15 (in unnamed module @0x67f946c3) cannot access class com.sun.org.apache.xpath.internal.XPathAPI (in module java.xml) because module java.xml does not export com.sun.org.apache.xpath.internal to unnamed module @0x67f946c3 when trying to install addons with the new version 2205. In fact every ant task that uses the "xmltask" task gets this error.
When trying to install the addon the old way with ". ./setantenv.sh" and "ant addoninstall" command everything works.

These are the added ANT_OPTS in setantenv.sh:
-Dpolyglot.js.nashorn-compat=true -Dpolyglot.engine.WarnInterpreterOnly=false
--add-exports java.xml/com.sun.org.apache.xpath.internal=ALL-UNNAMED
--add-exports java.xml/com.sun.org.apache.xpath.internal.objects=ALL-UNNAMED

Plugin version: 3.7.1.

Running the validateManifest task on a manifest for SAP CC 2211 (2211.1) with Integration Extension Pack 2211.0 fails with the error:

ERROR E-019 @ extensionPacks[0] No Integration Extension Pack available for SAP Commerce 2211.1

Looking in IntExtPackValidator, seems like the new version 2211 is not supported so far.

I will add the fix and submit a code patch.

• remove directory, use relativeLocation instead
• make relativeLocation a Path

Only keep (or extract, if possible) extensions that are used by the project, not the whole commerce zip file

Reduces size of the project on disk and help experts involved in different projects simultaneously.

Additionally, provide a way to update the project to remove all unused extensions and add new ones after changing localextensions.xml and/or manifest.json

Hello,

I'm encountering an issue with the sap.commerce.build.ccv2:4.0.0 plugin that validates the image version of an sap commerce before building. The plugin is currently unable to handle versions of SAP CC later than 2211. I specifically reproduce this issue with the version 2211.8 of SAP CC

Steps to Reproduce:

Include the in your Gradle build configuration.
Attempt to build the project with the version 2211.8
Observe that the plugin is reporting a version mismatch error even though the build number is the same being used in the cloud portal

Expected Behavior:

The plugin should correctly validate the image version of the artifact

Actual Behavior:
The plugin consistently reports a version mismatch error

Additional Information:

sap.commerce.build.ccv2 version: 4.0.0
SAP Commerce version with mismatched build number:2211.8
Expected build number: 2211.FP1

Any relevant logs or error messages: current version: 2211.FP1 (PREVIEW); required version: 2211.8 -> MISMATCH

portal-build-logs.txt

Environment:

Operating System: Mac OS
Java Version: OpenJDK Runtime Environment SapMachine (build 17.0.8+7-LTS-sapmachine)
Gradle Version: Gradle 7.6

Best regards,
Youssef El Jaoujat

https://guides.gradle.org/migrating-build-logic-from-groovy-to-kotlin/
https://docs.gradle.org/current/userguide/kotlin_dsl.html

maybe even use task configuration avoidance
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#header

Follow up to this PR discussion:

#43 (comment)

Gradle 8 seems to have new validation rules regarding Properties and related annotations?

https://docs.gradle.org/8.0.1/userguide/upgrading_version_7.html#changes_8.0.1

Bootstrap a Datahub project using scalding/gradle-waroverlay-plugin + akhikhl/gretty

https://github.com/scalding/gradle-waroverlay-plugin
https://gretty-gradle-plugin.github.io/gretty-doc/index.html

another overlay plugin:
https://plugins.gradle.org/plugin/io.freefair.war-overlay

The change done for #48 allows the build to complete, but it does a platform cleanup + extract for each build.

This is because SAP left the release 2211.8 still named 2211.FP1 in the platform version.properties, but in the manifest.json, the platform version must be set to 2211.8, not 2211.FP1, otherwise the build fails in CCv2.

If we want to run the build in CCv2 (and we do :) ), then we cannot name the dependency 2211.FP1, so we always get the cleanup+bootstap.

We need to map 2211.FP1 to 2211.8 in the plugin version parsing.

I will submit a patch.

Declare the task inputs and outputs of buildCCV1Package to make it easier to work with the task.

Declaring the outputs makes it easy to "post-process" the generated deployment package and checksum file

Looks like the build in CCv2 supports JSON with comments, which the plugin doesn't yet.