sap-samples / abap-platform-rap-opensap Goto Github PK

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit3.md

Since we want to use the results of the remote OData service that provides a list of travel agencies in our managed travel app that we created in week 2 and 3 we will create a custom entity.

In contrast to "normal" CDS views that read data from the database from tables or other CDS views the so called custom entities act as a wrapper for a code based implementation that provides the data instead of a database table or a CDS view.

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week3/unit6.md#step-7-preview-the-enhanced-travel-app--play-around

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit3.md#step-4define-the-composition-model

under 2.

composition [0..*] of ZI_RAP_Booking_#### as _Booking 

Screenshots for Week 3 - Unit 5 are missing (except for Step 1)

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-3
Explanation: Does it have enough admins on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit7.md#create-service-definition
Step 6 does not use an ALIAS as in the demo

The OSPO bot created this issue by mistake - It did not have enough priviledge to check the vulnerability alerts, So I am closing this issue now. Sorry for any inconvenience.

In the first part of this unit you have learned what needs to be done to publish a service binding for a Web API.

Subheading text ends abruptly - "This hands on script only shows the first part of the viedo for unit 7 since the second part that shows the creation of a "

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-license_file-1
Explanation: Does it have a license file? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Under heading "Short explanation: What has changed?"

This line was not removed:
@Metadata.ignorePropagatedAnnotations: true

Rather, it was this line:
@AccessControl.authorizationCheck: #CHECK

A shortdump is created if I enter a partial agency code (say, 9) in the Agency field and then leave the field with tab key. Using the search help as shown in the exercise is fine, of course.

The text of the dump shows this as root cause:
Unmanaged query API violation: Requested response not set via method IF_RAP_QUERY_RESPONSE~SET_TOTAL_NUMBER_OF_RECORDS

Debugging ZCL_CE_RAP_AGENCY_xxxx I see that filter_factory->create_by_range in get_agencies is throwing an exception, which means the request_count call later isn't performed and there we have the dump.

I have patched it with the following code, right before get_agencies:

IF io_request->is_total_numb_of_rec_requested(  ).  
  io_response->set_total_number_of_records( 0 ).  
ENDIF.

This way, a default value is provided and there is no dump when the range creation fails.

in https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit6.md#check-the-service-binding
and
in https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit6.md#test-access-to-entity-agency
you ask us to select the service binding of the Greenfield implementation, but you specify the service binding from the brownfield implementation of week 4

Note: the name of the service definition is correct

Refering to Week2, Unit 6, we named that Service binding ZUI_RAP_Travel_####
https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit6.md

ZUI_RAP_TRAVEL_O2_#### is the name of the Brownfield implementation service binding!!!

For Week 3, unit 2, step 2
https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week3/unit2.md#step-2-adjust-the-behavior-definition-of-the-travel-entity

The screenshot is,

and the code listed is below, instead of "1234" it should be "####"

Plus line 1 and 37 from the screenshot is missing,

looks like there is a similar issue for step 3

define behavior for ZI_RAP_Travel_1234 alias Travel
persistent table zrap_atrav_1234
lock master
//authorization master ( instance )
etag master LocalLastChangedAt
{
  create;
  update;
  delete;
  association _Booking { create; }

  field ( numbering : managed, readonly ) TravelUUID;

  mapping for zrap_atrav_1234
  {
    TravelUUID         = travel_uuid;
    TravelID           = travel_id;
    AgencyID           = agency_id;
    CustomerID         = customer_id;
    BeginDate          = begin_date;
    EndDate            = end_date;
    BookingFee         = booking_fee;
    TotalPrice         = total_price;
    CurrencyCode       = currency_code;
    Description        = description;
    TravelStatus       = overall_status;
    CreatedBy          = created_by;
    CreatedAt          = created_at;
    LastChangedBy      = last_changed_by;
    LastChangedAt      = last_changed_at;
    LocalLastChangedAt = local_last_changed_at;
  }
}

I am following the link to add the behavior definition .

On Fiori Preview I cannot see the Edit and Create button. The data is getting displayed correctly.
I have also tried creating new service Binding, Deleted the Cache, Changed the Default Browser to Edge and Chrome, but its not working .

I am using ABAP Trial Account f or SAP BTP

The Behavior Definition for both Entity View and Projection view is created as below

managed; // implementation in class zbp_i_rap_travel unique;

define behavior for ZI_Rap_Travel alias Travel
persistent table ZRAP_ATRAV
lock master
//authorization master ( instance )
etag master LocalLastChangedAt
{
  create;
  update;
  delete;
  association _Booking { create; }
  field (numbering : managed, readonly) TravelUUID;

   mapping for zrap_atrav
  {
    TravelUUID         = travel_uuid;
    TravelID           = travel_id;
    AgencyID           = agency_id;
    CustomerID         = customer_id;
    BeginDate          = begin_date;
    EndDate            = end_date;
    BookingFee         = booking_fee;
    TotalPrice         = total_price;
    CurrencyCode       = currency_code;
    Description        = description;
    TravelStatus       = overall_status;
    CreatedBy          = created_by;
    CreatedAt          = created_at;
    LastChangedBy      = last_changed_by;
    LastChangedAt      = last_changed_at;
    LocalLastChangedAt = local_last_changed_at;
  }
}

define behavior for ZI_RAP_Booking alias Booking
persistent table ZRAP_ABOOK
lock dependent by _Travel
//authorization dependent by <association>
etag master LocalLastChangedAt
{
  update;
  delete;
  association _Travel;
  field (numbering : managed, readonly) BookingUUID;
  field (readonly) TravelUUID;

  mapping for zrap_abook
  {
    BookingUUID        = booking_uuid;
    TravelUUID         = travel_uuid;
    BookingID          = booking_id;
    BookingDate        = booking_date;
    CustomerID         = customer_id;
    CarrierID          = carrier_id;
    ConnectionID       = connection_id;
    FlightDate         = flight_date;
    FlightPrice        = flight_price;
    CurrencyCode       = currency_code;
    CreatedBy          = created_by;
    LastChangedBy      = last_changed_by;
    LocalLastChangedAt = local_last_changed_at;
  }

}

For Projection View

projection;

define behavior for ZC_RAP_Travel alias Travel
use etag
{
  use create;
  use update;
  use delete;

  use association _Booking { create; }
}

define behavior for ZC_RAP_Booking alias Booking
use etag
{
  use update;
  use delete;

  use association _Travel;
}

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week4/unit3.md#step-2-create-control-structures-and-mappings

The coded snippet in step 2.10 has the description 'Input flag structure for node Booking' while everywhere else you refer to it as 'Control structure booking'

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit5.md#step-2-annotate-the-booking-projection-view
see 2.

Underscore at wrong position
name and a meaningful description (e.g. UI Annotations for ZC_RAP_Booking_####)

In https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit5.md, step 7, the following annotation is used

@ui: {
headerInfo: { typeName: 'Travel',
typeNamePlural: 'Travels',
title: { type: #STANDARD, label: 'Travel', value: 'TravelID' } } ,
presentationVariant: [{ sortOrder: [{ by: 'TravelID', direction: #DESC }] }] }

But this is giving following HTTP error when I am executing the fiori element preview from service binding.

{"error":{"code":"005056A509B11EE1B9A8FEA8DE87F78E","message":{"lang":"en","value":"Property desc not found in type TravelType"},"innererror":{"transactionid":"B59C0F42C9AF00D0E0064C6C73AFDC9D","timestamp":"20230731132547.3575230","Error_Resolution":{"SAP_Transaction":"For backend administrators: use ADT feed reader "SAP Gateway Error Log" or run transaction /IWFND/ERROR_LOG on SAP Gateway hub system and search for entries with the timestamp above for more details","SAP_Note":"See SAP Note 1797736 for error analysis (https://service.sap.com/sap/support/notes/1797736)"}}}}
--440328ACE08C04162E2AD8A5960092FD0--

The reason for the error is, the URL which is generated is -
GET Travel?sap-client=100&$skip=0&$top=20&$orderby=%20desc&$select=TravelId%2cAgencyId%2cAgencyName%2cCustomerId%2cCustomerName%2cBeginDate%2cEndDate%2cBookingFee%2cCurrencyCode%2cTotalPrice%2cDescription%2cTravelStatus%2cTravelUuid&$inlinecount=allpages HTTP/1.1

Here in the orderby=%20desc& is not containing the TravelID as mentioned in the @ui annotation. Could you please check and help me.

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit7.md#create-service-binding

Service binding
a) does not show Travel with Alias as it was not provided in Code snippet.
b) does show ZCE_RAP_AGENCY_#### - the Agency extension from ES5' we just added in unit 5+6 (you might want to add a note, that beginners do not get confused)

You should add a comment that in newer version 'Activate' button was replaced by 'Publish' button and that you need to activate Service binding before pressing 'Publish'

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-1
Explanation: Does it have enough teams on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week3/unit6.md#step-1-create-the-message-class

In step 5 the picture that shows the message text has the same text for message 001 and 002 although they are listed in a markdown table correctly just above

The file W5U7_SRVD_ZAPI_RAP_TRAVEL_%23%23%23%23.txt is missing in the folder https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/sources:

@EndUserText.label: 'Travel Web API'
define service ZAPI_RAP_TRAVEL_#### {
  expose ZC_RAP_TRAVEL_#### as Travel;
}

Hi,
as described in the script a data defintion should be created. In my case such data definition is not created.
Is the script outdated?
BR, Eddy

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week4/unit3.md#step-2-create-control-structures-and-mappings

The coded snippet in step 2.5 has the description 'Flag structure for Travel data' while everywhere else you refer to it as 'Control structure travel'

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit6.md#step-2-create-the-service-binding

The button has been renamed from 'Activate' to 'Publish'

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-2
Explanation: Does it have an admin team on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week2/unit3.md#step-4define-the-composition-model
under 4.

 association to parent ZI_RAP_Travel_####        as _Travel     on  $projection.TravelUUID = _Travel.TravelUUID