sanjeevspr / asterisk-php-api Goto Github PK

[deleted issue]

What steps will reproduce the problem?
1. show queues
2.
3.

What is the expected output? What do you see instead?
The expected output is many lines which show all of the queues and their
status. What we see is one line which says Response: follows. This is
because you are using fgets to read the response, I am no expert but I
believe stream_read_contents would be the appropriate call here. It will
read the entire contents instead of just the first line.

What version of the product are you using? On what operating system?
latest version from svn as of 4/16/08 @ 6:21pm PST

Please provide any additional information below.
199 #        $response = fgets($this->_socket);
200         $response = stream_get_contents($this->_socket);

ListCommands returns a list of available manager commands.

Don't Repeat Yourself.  Need to wrap the connection check into its own method.

What steps will reproduce the problem?
1. Originate a call to a channels you can answer (SIP/IAX Softphone)
2. Wait until the socket timeout comes
3. then an execption is thrown

I manage the problem by changing a little the code. I can send you the 
code, so you can take a look a it.

I have added the ExtensionState command too, just let me know if would like 
to see it (I saw an issue/enhancement with this). 

Can contact me at: jerdguez _at_ gmail _dot_ com

This command enables you to query the server for the state of an extension.

fputs is an alias of fwrite.  May as well use fwrite.

MailboxCount returns the number of new and old messages in a given
voicemail account.

Implement PEAR_Exception handling to conform with PEAR guidelines for
submission.

Nice job maintaining this.  I hastily wrote some PHP code to work with the
Asterisk AGI as well.  There are a couple features that are missing that
would allow me to use this as a replacement.

If you are interested  in adding a couple features, I can give you more
info and help out.

The functions I primarily use are CoreShowChannles, Park, ParkedCalls,
QueueAdd(with agent number), queue pause, and probably a couple others.

Thanks!

Each method currently executes the fputs command multiple times - once for
each line.  Although this helped readability in the past it is now
appearing messy and is excessive.

Critical as there's no method for stopping a monitor command currently in
the dev release.

Mailbox status command provides information on given voicemail box.

Extend the PEAR_Exception class using class constants to define exception
types.

What steps will reproduce the problem?
1. Use Challenge login with Asterisk
2. Login fails


What version of the product are you using? On what operating system?
Does not matters.

Please provide any additional information below.
The issues is in AsteriskManager.php line 200
-strpos($response, "Challenge: ")));
+strpos($response, "Challenge: ")+strlen("Challenge: ")));

Otherwise the challenge is wrong and authentication fails

Hi, 

when passing variables to originate call function like: 

  /**
  * Originate Call
  */

  try {
     $ast->originateCall ('1000', 'SIP/provider/+123456789' , 'outgoing', '+122222092', 1, 30000, array("FOO"=>"value1", "BAR"=>"value2"));
  } catch (PEAR_Exception $e) {
      echo $e;
  }

I would expect to have those variables available in my dialplan:

[outgoing]
exten => 1000,1,Background(/data/sounds/beep)
  same => n,Background(/data/sounds/${FOO})
  same => n,Background(/data/sounds/${BAR})
  same => n,Hangup()


They are not. 

Am I missing something? Can this be achieved?

Thank you

I've made some changes for my own use that eliminate having to wait for the 
3 second timeout on many operations (by looking for a known termination 
keyword and not reading any further).

This patch also adds an option to supply "Events: off" on login.

Patch attached

What steps will reproduce the problem?
1. Originate a call with Variables arg.

What is the expected output? What do you see instead?
Command: Originate...Variable: foo=bar|baz=2
Command: Origiante...Variable: Array

What version of the product are you using? On what operating system?
N/A


Please provide any additional information below.

Patch:
--- AsteriskManager.php 2009-03-01 18:24:02.000000000 -0600
+++ AsteriskManager.php.original        2009-03-01 18:24:26.000000000 -0600
@@ -323,7 +323,7 @@
                 $chunked_vars[] = "$key=$val";
             }
             $chunked_vars = implode('|', $chunked_vars);
-            $command     .= "Variable: $chunked_vars\r\n";
+            $command     .= "Variable: $variables\r\n";
         }

         if ($action_id) {

really liking the API so far, but one thing missing thing i need is a 
secure login option.

attached patch implements the MD5 auth type by extending the login 
function to perform it's job based on the passed auth type.

tested, and seems to work beautifully.

happy to rewrite if you don't like the approach -- just lemme know....

Connect method doesn't return anything even though the docs say it returns
a bool

Current code uses stream_get_contents which wait for EOF or timeout.

Tha attached patch consider the command responded when an empty line is sent.