Git Product home page Git Product logo

cmp1903_a1_2324's People

Contributors

markdoughty avatar sanjana978 avatar

cmp1903_a1_2324's Issues

Code Review - David Lenihan

Have the requirements been met?
Some requirements have been met, such as the usage of int(Roll) and there is proof of 3 dice being rolled. However, the rest of the requirements have not been quite met, as the code does not properly run. Furthermore, some requirements are either improperly used or omitted, for example Debug.Assert() is present in the code however not used properly.

Is the code formatted using the Style Guidelines correctly?
Some code is formatted well, however most of it does not quite follow the guidelines.

Is the code easy to read?
The code is readable and the concepts can be understood, however the code is poorly ordered and lacking in comments.

Are different errors handled correctly?)
There was an attempt to handle errors, however the usage of Debug.Assert is used incorrectly and thus will not check anything.

Overall comments
The code was a good attempt and it is clear to understand the goals you were going for. However, the code definitely needs polishing in order to run and meet the requirements.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.