samuelcole / marchbnb Goto Github PK

On my Google Pixel phone (also reproducible by making a window the width of a phone), the body of the site gets hidden behind the vertically-stacked footer links. See attached.

Otherwise, they see the sign-in screen, which is confusing if you're already logged in.

Opening page:

• Replace HillaryBNB logo with image from Ryan Schroeder. (2ff1ff7)
• Link to FAQ still going to HillaryBNB-branded FAQ. Needs to point to MarchBNB FAQ. (fixed by 54c9959)
• Feedback page needs to be edited to replace HillaryBNB branding and content.

Profile page:

• Email content needs to be edited to remove HillaryBNB branding and replace hillarybnb.com email address with marchbnb.com. (3f6058a..ae215db)
• Also need to change [email protected] to [email protected]. (fixed by a839cc8)

Main page:

• HillaryBNB logo needs to be replaced. (2ff1ff7)
• Change "On the road for Hillary?" to "Coming to the march?" (99d09da)

Host page (I can host)

• Can we default the calendar to January 2017? (74c2e8d)

Travel page (Find a host):

• Can we default the calendar to January 2017? (e885aee)
• When I created a travel request with the same zip and dates, no hosts showed up. I should have been able to see my host request, correct? Unless there is something preventing a traveler and a host with the same account?

(from @robmyre's text file)

Meta tag says

and

Makes the preview on FB misleading.

The confirmation email still shows a hillarybnb.com address:

Google authentication is not working. Getting a 400 error.

Currently, we're using logo_dark in the header of the home/user pages. logo_light exists for when we have the background image behind it. The background image is in assets/images, and should have a background: cover style and should probably be part of a partial that is used in both the home/user pages.

I'm a tech volunteer helping the Women's March with their digital tools. Vanessa Wurble head of Operations for the March and other national committee members have noticed your app and appreciate the work! Housing matching is a huge need right now as hotel prices are through the roof! For various liability reasons, they can't release their own application officially, so they're rooting for yours to catch on. I'm going to give you their style guide, you should consider using their branding (maybe not the logo though). https://docs.google.com/presentation/d/16j4rBmYAG1Zz3jC4MA3QZYoWv-WVePhp3coL16NgTmU/edit#slide=id.p

If you think your app can handle it, I'm going to reach out to various promoters about it. Your traffic may increase drastically, so let me know if you're ready.

Finally, I noticed some of your group wants to stay politically active through tech. Our organization, Blue Boost founded the day after the election to help progressive causes and campaigns with digital tools could use more talented devs. I'd like to extend an open invitation to any of your contributors. We also recommend progcode.co. We work closely with that network.

Keep up the good fight!

When setting up my development environment for the first time the sudo docker-compose build command fails with the following error:

warning: parser/current is loading parser/ruby22, which recognizes warning: 2.2.5-compliant syntax, but you are running 2.2.3. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

Another developer that I was working with had the same issues.

We seem to be getting this error because the parser library isn't compatible with Ruby 2.2.3. However, the Ruby version is hardcoded into the heroku/ruby image, which is referenced in the Dockerfile.

There seems to be two possible solutions to this issue. First, we could just create our own version of the heroku/ruby image but make it use Ruby 2.2.5. This would solve the Ruby version issue but I don't know if what we end up generating would work on Heroku. I checked the supported Ruby versions on Heroku today and couldn't definitively answer whether Ruby 2.2.5 is even supported.

The next possibility is to force a version of the parser library that does support Ruby 2.2.3 (like this one). This may solve our problems in the short term but who knows for how long? At best it's a band-aid.

I'll test both solutions myself soon to see what works, but since I'm new to the project I was wondering about the following:

1. What's the preferred choice of the project maintainers?
2. Is it worth examining a non-Heroku-based hosting solution? The Heroku Ruby Docker image has been stuck on version 2.2.3 for 2 years now. It doesn't appear that Heroku is investing lots of time and effort into this deployment method. Would it be better to look into a more traditional Heroku or Docker-based deployment method?

This is related to issue #34.

We need to remove the Heroku-Docker dependency from this application because it is a) broken and b) unnecessary. This change affects the following:

• README.md - The published processes for setting up a dev environment and pushing code need to change.
• ??? - I'm assuming that a few Heroku-related config files will need to change slightly.

I'm happy to help provide some PR's to make this work but I am not a Heroku expert so it might take me a while :-)

And I checked my spam/junk file. I want to sign up as a host.

The feedback form is HillaryBNB-branded. I don't know if we want to modify it, remove it, or replace it with a new MarchBNB-branded form. @robmyre / @samuelcole, thoughts?