samolego / clientstorage Goto Github PK

Hi, can you update this mod to work on 1.20?

(Mirror of: Andrew6rant/InventoryTabs#73)
The tabs from InventoryTabs overlap with the UI inside the Crafting Table.
Adding crafting_table to the list of excluded blocks in InventoryTabs does not resolve the issue. (doesn't have any effect)

It would be much appreciated if you could look into this!

Crash report: https://mclo.gs/Di9R44S

Steps to reproduce:

Place a crafting table a good distance away from any chests or other storage
Right click

Expected behavior

Crafting table screen opens

Actual behavior

Crafting table screen NEVER opens.

Video Demo:

Hello! I really like this mod, can you make the 1.20.6 update please.
Thank you so much!

I don't really understand debug mode things but can you atleast what the "inventory size mismatch" means and yeah I sometimes can't store and retrieve items from chests

The server also has anticheat so that maybe the problem? Also, when that bug happens, and I open the crafting table again, most of the items are gone and won't come back until I open the chest that contains the item I'm looking for

In the creative mode inventory, the scroll bar gets greyed out when there is not enough items to scroll.

However, this behavior is not present in ClientStorage.

As long as the cursor is aligned with the x value of the scroll bar, it can be accessed from anywhere on screen

Not really sure what's going on here, but the behavior is quite inconsistent for me

https://streamable.com/4c50rd

Modlist

I'm running a Minecraft 1.19.2 server using Paper. (derivative of Bukkit)
(Paper build 1.19.2 - 237)

The ClientStorage 1.2.1 Bukkit plugin fails to load with the following error:

[13:23:02 ERROR]: Could not load 'plugins/clientstorage-bukkit-1.19.2-1.2.1.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: Cannot find main class `org.samo_lego.clientstorage.bukkit.ClientStorageBukkit'
	at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:73) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:153) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:411) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:319) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_19_R1.CraftServer.loadPlugins(CraftServer.java:423) ~[paper-1.19.2.jar:git-Paper-237]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:278) ~[paper-1.19.2.jar:git-Paper-237]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1100) ~[paper-1.19.2.jar:git-Paper-237]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-237]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.ClassNotFoundException: org.samo_lego.clientstorage.bukkit.ClientStorageBukkit
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:177) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:124) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at java.lang.Class.forName0(Native Method) ~[?:?]
	at java.lang.Class.forName(Class.java:467) ~[?:?]
	at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:71) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	... 8 more

Tested on both Linux and macOS.

Linux:

$ uname -a
Linux hostname 5.19.0-1-amd64 #1 SMP PREEMPT_DYNAMIC Debian 5.19.6-1 (2022-09-01) x86_64 GNU/Linux

$ java -version
openjdk version "17.0.4.1" 2022-08-12
OpenJDK Runtime Environment Temurin-17.0.4.1+1 (build 17.0.4.1+1)
OpenJDK 64-Bit Server VM Temurin-17.0.4.1+1 (build 17.0.4.1+1, mixed mode, sharing)

macOS:

% uname -a
Darwin hostname 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64

% java -version
openjdk version "17.0.5" 2022-10-18 LTS
OpenJDK Runtime Environment Zulu17.38+21-CA (build 17.0.5+8-LTS)
OpenJDK 64-Bit Server VM Zulu17.38+21-CA (build 17.0.5+8-LTS, mixed mode, sharing)

I was looking at this issue, and I saw that the transparent resource pack that was being used led to darker parts of the GUI due to rendering overlap.

https://gist.github.com/ProsperCraft/7342b89f0d5d4ca71b873e770c3c4e6b

Modpack - https://www.curseforge.com/minecraft/modpacks/my-friends-play-without-mods

seems to be being caused by a conflict with YOSBR

https://mclo.gs/tlSFgT5

Mod doesnt work on 1.19.4 Quilt.

Since we have the available storage data, it'd be really simple to calculate the "fullness" of the storage. Rendering it ... well that'd be a it harder 😛

This mod crashes if I load it with Polymer
mclog.txt

For some reason I can't open furnaces if I use "Open to LAN" option and then crash if I try opening my inventory.

How to reproduce the issue:

1. Open any world
2. Open the world to lan
3. Right click a furnace (nothing happens, furnace gui isn't showing up)
4. Press e to open inventory
5. Game crashes

Other things I've noticed

• If you hold Shift while clicking, furnace gui opens as usual, no crashes either.
• If you open any other gui (chest, barrel, crafting table, etc) after clicking a furnace, you also won't crash.
• If the mod is disabled via in-game config, furnace gui works without issues.

Crashlog: https://mclo.gs/KvKiwvO

https://mclo.gs/SYn866S
Seems to be a conflict with YetAnotherConfigLib

Would like to be able to get 1.20 through modrinth instead of going to curseforge

I don't know if I'm doing something wrong, but in general, input items both from the menu and from the chest cause syncing issues which break taking any unsynched items out.

Tested in Singleplayer, Paper Server, and Vanilla server with Cache Container enabled and disabled.
Item Transfer settings were also enabled and disabled for container testing
Tested with only fabric API mod and Yet Another Config and the bugs still persisted (in the video I had performance and visual mods)

This video shows most of the bugs, in chronological order:
Input to the menu doesn't work in any way I tested, causing syncing issues
Taking the unsynched items away causes glitches
Putting items into the chest sometimes rechecks, causing duplication visual glitches and syncing issues (sometimes it doesn't recheck and doubles only once, still unsynced though)
(Not shown) Taking the unsynched items away also causes glitches
Taking the items away from the container directly doesn't correctly update the menu if unsynced
https://user-images.githubusercontent.com/70297682/198537801-e4e4dbd1-e51a-490e-8c9e-a0b46316385b.mp4

Hard to make it actually work, but when it does sync correctly (rarely works when putting items into the container), taking items out from the container works fine. Item transfer is still sometimes buggy as it sometimes drags; sometimes goes straight into inventory; sometimes goes into inventory, and then clicks again and now you are dragging a different item (possibly due to syncing issues though). If this is too complicated, there should be a setting to just put straight it in the inventory to avoid this bug.
https://user-images.githubusercontent.com/70297682/198537760-ae6ee768-d1c2-4946-a818-25d288b50c08.mp4

Perhaps hardcode it so Chest/Hopper minecarts/boats are only searched by default, with a config option to add more entities later.

this is the log, it simply just seems to be crashing when opening the crafting table and NoRecipeBook or any such related mod is enabled.

https://mclo.gs/hbtgzdd

Error in Mod menu:

Crash report
crash-2023-12-22_13.54.28-client.txt

like Wood products going in wood labeled chest. Long shot but would be nice to use when played with other people using same chests!

have tried deleting other mods, and unload all resourcepacks, no luck
fabric 1.19.4-0.4.14
the latest version of this mod

I don't know how exactly this mod works, but it appears to be easily detectable by anticheats.
So, I think a cool improvement would be a toggle that disables the ability to take the item without opening the chest, and it would allow you to search through chests you've already opened (the insides of the chest are stored client-side), and when you search it, and select the item, it would show you which chest has it, and maybe even highlight the item when you open the chest.

Tested with v 1.3.1 and v1.3.0 on 1.19.2, same crash

Only other mods enabled:
Fabric API 0.68,0-1.19.2
yacl 1.7.1

crash-2022-12-10_18.37.06-client.txt

https://pastebin.com/YbH4NrYA
when opening an Computer Craft: Restitched Turtle, it crashes,
this is on latest for 1.19.3.

I see in the releases tab here on github there are builds for newer minecraft versions, but modrinth only has builds up to 1.20.2

It would be awesome if there was a command to search for a specific block within a radius. For radius' larger than 6, it should use the cache.

Examples:

Search within the radius set in the settings

Command:
/search stone

Results (in chat):

4x   @ 1, 64, 1
450x @ 1, 65, 1

Search within a provided radius (using the cache for containers further than 6 blocks)

Command:
/search stone 12

Results (in chat):

4x   @ 1,  64, 1
450x @ 1,  65, 1
50x  @ 10, 64, 1

Logged in the chat on connection:

[21:18:20] [Render thread/INFO]: [System] [CHAT] [ClientStorage] Server type quilt is unknown. Please set appropriate packet delay in config.

For some reason, even with single chests, it keeps reading double the amount of items in nearby chests. (Like two iron swords with durability 15, despite only being 1 of them)