sammyjo20 / lasso Goto Github PK

@Sammyjo20 This is a great package! It would be so cool if we can use Lasso for non-Laravel projects.

Cheers

It would be nice to set publish and pull webhooks per lasso_env. For example when using envoyer, i would like to trigger another project when going to staging.

Example: export AWS_SECRET_ACCESS_KEY=invalid-key && php artisan lasso:publish

Output makes you think all is good when it is not.

#65 should resolve it.

Love Lasso, and through usage I've found a couple of parts that I think could be nicer for the user.

When running php artisan lasso:publish the progress simply says "filesystem". I think it would be nicer if it showed the name of the disk that you're uploading to, too!

e.g. current setup:

Preparing to publish assets to Filesystem.

Proposed change:

Preparing to publish assets to "assets" Filesystem.

Hi Sam,

Firstly, thanks for this package!

I'd like to ask what's the reasoning for managing bundles during pull rather than during push?

The reason I ask is because if history and bundles were managed during push I could distribute read-only access credentials to the majority of users, which would allow them to pull, and manage builds and pushing in the CI pipeline. Currently, if read-only credentials are used the PullJob fails at the VersioningService::appendNewVersion() step so it's not possible.

i've always considered committing to git in the CI process to be fraught with peril. I would think the sensible default to be storing the version manifest on a remote filesystem. Perhaps possible to pull the version from that remote disk as part of the push process so that a version history could be maintained?

I noticed an issue with using Lasso across multiple servers on Envoyer. Occasionally, they try to write the history.json file at once.

Hey @Sammyjo20

First of all, awesome stuff you're building here!

Today we've spent some time in the company experimenting with Lasso. We use Laravel Forge & Envoyer in combination with Github Actions to deploy our applications. For storing our assets, we've decided to use S3.

Laravel Envoyer is creating a new release for each deployment. So even if there is a history within your lasso folder we need every time a fresh pull from the S3 Server. Because of this reason we thought we can ignore the lasso-bundle.json.

If there is no history.json within the lasso folder the lasso:pull is working without any problems. But if there is an existing history.json in the file we receive the following error.

An exception was thrown. Reason: A valid "lasso-bundle.json" file could not be found in the Filesystem for the current environment.

Maybe we missing something but is there a way to provide something like a php artisan lasso:pull --force command, to receive always just the latest version? With ignoring the exiting lasso-bundle.json?

As a quick-fix: We've added the initial lasso-bundle.json back to the public folder.

Cheers
Sebastian

If your application's config is cached, installing Lasso will break the application (making the config cache unable to be cleared as well).

Since Lasso always registers into the container (#23) it will break when the Filesystem helper attempts to instantiate, due to null being passed to setCloudDisk() as that's what is returned from the config() helper due to no Lasso configuration being cached (it would break on setPublicPath() as well).

A temporary fix until #23 is resolved would be to just provide defaults for the config values here, like is done already for lasso.storage.environment.

Lasso's environment management system is pretty useful, but can be clunky if you are working locally.

Adding a "--lasso-env=" flag to the publish command will upload your files to an exact environment.

Use the history.JSON file to keep track of all the bundles, not just for versioning but also to delete bundles that may have been created but never used.

Some people may experience a memory limit error during the “upload” phase of the “publish” command. This is due to me not using a stream to store the contents of the Zip file. I will update this to use a stream which should resolve it. But I wanted to add this as a known issue!

When trying to ignore .DS_Store files from my computer none of these rules seem to work

'excluded_files' => ['DS_Store', '*.DS_Store', '.DS_Store']

Hi,

Laravel Version ........................................................................................................................... 9.39.0
PHP Version ................................................................................................................................ 8.1.5
Composer Version ........................................................................................................................... 2.2.8
Environment ................................................................................................................................ local

I'm using Digital Ocean Space for uploading & Downloading compiled assets using Lasso.
php artisan lasso:publish command working without any error. But when using lasso:pull on deployment script, it's throwing an error.

php artisan lasso:pull

🏁 Preparing to download assets from "digitalocean" filesystem.
⏳ Reading Bundle meta file...
⏳ Downloading bundle...
✅ Successfully downloaded bundle.
⏳ Creating backup...
✅ Backed up.
⏳ Updating assets...

League\Flysystem\UnableToCheckDirectoryExistence

Unable to check existence for: lasso/global/history.json

at vendor/league/flysystem/src/UnableToCheckExistence.php:19
15▕ }
16▕
17▕ public static function forLocation(string $path, Throwable $exception = null): static
18▕ {
➜ 19▕ return new static("Unable to check existence for: {$path}", 0, $exception);
20▕ }
21▕
22▕ public function operation(): string
23▕ {

  +41 vendor frames

42 artisan:37
Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Vite supports multiple environments via specifying a flag --mode {stage} during build command: https://vitejs.dev/guide/env-and-mode.html

The problem is when building on local with lasso vite for some reason ignores these .env.{stage} files. In documentation it is said that:

In addition, environment variables that already exist when Vite is executed have the highest priority and will not be overwritten by .env files. For example, when running VITE_SOME_KEY=123 vite build.

Can it be related that Lasso runs vite and passes the same environment as laravel currently have which overrides variables from .env.{stage} files?

When publishing assets on Windows and pulling them into Linux, the asset directory structure is not properly preserved. Instead after unzipping, assets include the path with backward slashes in the filename (e.g. assets\css\bootstrap.min.css).

I assume that happens because directory separators are hard-coded as forward slash (/), but should use the PHP global constant DIRECTORY_SEPARATOR to avoid cross-platform issues with path names.

I recently installed this package. It looks like the max_bundles setting is not working correctly. My setting is set to 5 bundles.

Hey, will Lasso add PHP 8 support soon?

I may be missing something really obvious and if so I apologize. The Lasso workflow is like:

• Run lasso:publish on my local machine or in CI and a zip file is placed on a filesystem
• Run lasso:pull on the server and it grabs that zip file and unzips it so the built assets can be served to visitors

I have a perfectly good CDN sitting around (that's where the zip file is uploaded to). Is there no way to have the JS/CSS bundles be put onto the CDN (unzipped) so my website visitors can download assets from the CDN instead of from y webserver?

Kudos to this package! This is really an awesome tool for Laravel.

Is it possible to exclude filenames using wildcards? I tried using wildcards but it does not work.

Thanks!

Hello there,

I tried to compile assets during Github CI/CD. All my php unit tests run successfully but when it comes to compiling the assets using php artisan lasso:publish , it fails, see the error screenshot below.

It works on my localhost and successfully uploads the assets.

Looks like it cannot connect to the database, however php unit tests are passed in the same workflow and they do connect to the database.

Here is the part of workflow to lasso publish:

    - name: Compile & upload assets
        if: ${{ github.ref == 'refs/heads/production' && github.event_name == 'push' }}
        env:
          DROPBOX_TOKEN: ${{ secrets.DROPBOX_TOKEN }}
        run: php artisan lasso:publish --no-git

This is the error I get on github actions:

I have a feeling the recent update to 2.0.2 is causing the below error during publishing to s3. I'm on Laravel 8.

Uploading asset bundle to "s3" filesystem...

Illuminate\Contracts\Filesystem\FileExistsException 

File already exists at path: [path to file]/lasso-bundle.json

I rolled back to 2.0.1 and the error is gone.

The "hot" directory is left by Webpack in local development environments, so this should be ignored for production assets. This will need to be added to the "forbiddenDirectories" array in Sammyjo20\Lasso\Tasks\Publish\BundleJob.

Hello,

I ran into an error when using sail artisan lasso:publish with Laravel Sail. However, I was able to publish the assets successfully without using Sail php artisan lasso:publish on my laptop.

Wondering if there are any configurations to be added/changed when using with Sail?

Lasso version: ^1.2
Laravel: 8.70.1
PHP: 7.4.2

I am facing some issues when pulling assets php artisan lasso:pull from s3 filesystem during Github CI/CD.
For some reason, it fails to check for the assets zip file existence.

This is the error message I am receiving:

🏁 Preparing to download assets from "s3" filesystem.
⏳ Reading Bundle meta file...
⏳ Downloading bundle...
   League\Flysystem\UnableToCheckDirectoryExistence 

  Unable to check existence for: lasso/global/pEaCXUnSNKBXNvP03RRT.zip

  at vendor/league/flysystem/src/UnableToCheckExistence.php:19
     15▕     }
     16▕ 
     17▕     public static function forLocation(string $path, Throwable $exception = null): static
     18▕     {
  ➜  19▕         return new static("Unable to check existence for: {$path}", 0, $exception);
     20▕     }
     21▕ 
     22▕     public function operation(): string
     23▕     {

      +43 vendor frames 
  44  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()
Error: Process completed with exit code 1.

Here is my s3 config:

's3' => [
      'driver' => 's3',
      'key' => env('AWS_ACCESS_KEY_ID'),
      'secret' => env('AWS_SECRET_ACCESS_KEY'),
      'region' => env('AWS_DEFAULT_REGION'),
      'bucket' => env('AWS_BUCKET'),
      'endpoint' => env('AWS_URL'),
],

I can confirm that the file does exist in the S3 bucket using tinker and web UI.

Psy Shell v0.11.8 (PHP 8.1.12 — cli) by Justin Hileman
>>> Storage::disk('s3')->exists('lasso/global/pEaCXUnSNKBXNvP03RRT.zip')
=> true

Right, we need to get some tests in here!

I was wondering how specifically is the best way to test Lasso. Would the best way to test each individual component, e.g the backing up process?