The craftcms-shortcodes from samhernandez

craftcms-shortcodes's People

Contributors

Stargazers

Watchers

craftcms-shortcodes's Issues

Shortcode attributes break if no space before closing bracket

My environment - Apache/2.4.10 (Unix) PHP/5.5.24 / Craft 2.4.2691

Firstly, great plugin!

I'm having an issue with shortcode attributes breaking twig when there is no space before the closing bracket.

[button slug="careers" color="purple" type="pill"]More[/button] Breaks twig

[button slug="careers" color="purple" type="pill" ]More[/button] Works as expected

and the shortcode function...

public function button($attributes, $content, $tag)
    {
        // Build the button classes
        $classes = [];

        if(isset($attributes['color'])) {
            $classes[] = 'btn--' . $attributes['color'];
        }

        if(isset($attributes['type'])) {
            $classes[] = 'btn--' . $attributes['type'];
        }

        if(count($classes)) $classes = implode($classes, ' ');

        // Build the button

        if(isset($attributes['slug'])) {
            $url = $this->getUrlFromSlug($attributes['slug']);
            if(!$url) {
                $button = '<span class="btn btn--error">Invalid slug</span>';
            } else {
                $button = '<a href="' . $url . '" class="btn ' . $classes . '">' . $content . '</a>';
            }

            return $button;
        }

        if(isset($attributes['external'])) {
            $button = '<a href="' . $attributes['external'] . '" class="btn ' . $classes . '">' . $content . '</a>';

            return $button;
        }
    }