dot files in /home/redmine about docker-redmine HOT 12 CLOSED

@b-a-t As par as I can tell the contents of .subversion/ would include the saved password or proxy server config, etc. I don't think this is required to be persistent in the container, Since for subversion alteast the username / password is specified web page. But even if it has to be saved, its not a big issue. I already save the contents of the .ssh directory in my gitlab container.

I can add this, however you will need to test it out and confirm that it works / doesn't work

from docker-redmine.

We are using only SVN at the moment, so I can only test that. And I will :) In general I got the impression that SCM related side of the redmine isn't very popular/not tested in all possible combinations, as, for example, crash of SVN client was fixed only with your last commit, where unicorn is run from redmine user and properly set HOME. I faced with that problem myself and made exactly the same fix, but seems someone reported it earlier.

In our SVN setup we are running svn+ssh on a non-standard port and that enforces us either to define it in .ssh/config or in .subversion/servers. This data can't be set in redmine itself, hence its nice to have it persistent somehow.

And, as I spammed you today with all that small issues, I also want to thank you for the great work you've done!

from docker-redmine.

@b-a-t

fixed only with your last commit, where unicorn is run from redmine user and properly set HOME

It was not reported by anyone. I just happened to notice that unicorn was being run as the root user and changed it to redmine. I didn't even know that running unicorn as root could cause issues.

For git redmine only allows you to specify the path of the repo on the file system. No http / ssh or anything. The repo has to be accessible locally. Same goes for mercurial and bazaar. SVN is the exception here.

In our SVN setup we are running svn+ssh on a non-standard port

Will keep this in mind.

from docker-redmine.

I've noticed the problem trying to make Redmine recognize all the SCMs and being surprised, why SVN was showing me (!) . It turned out that combination of unicorn being started with root environment, but changed UID leads to:

$ HOME=/root svn help
svn: warning: W000013: Can't open file '/root/.subversion/servers': Permission denied
Segmentation fault

from docker-redmine.

@b-a-t I think adding environment=HOME=/home/redmine in addition to running unicorn as redmine user should resolve this (these changes are already present in latest).

from docker-redmine.

@sameersbn yes, latest works fine with SVN now, thank you! Also I like how appStart() looks and works now. No need to worry about over flooding 'docker logs' storage among other things.

from docker-redmine.

Thanks for this one! But as it is in DATA_DIR Redmine won't actually see and use it? Shouldn't you symlink it to the HOME dir?

And .ssh is still more essential for me... May I suggest to introduce REDMINE_DOT_FILES variable and have smth. like in /app/init:

for dot in ${REDMINE_DOT_FILES}; do
    sudo -u redmine -H ln -snf ${DATA_DIR}/${dot} /home/redmine/${dot} || true
done

So those, who don't need any dot files won't get any and the rest may expose files or dirs from DATA_DIR that essential for them?

from docker-redmine.

Thanks for this one! But as it is in DATA_DIR Redmine won't actually see and use it? Shouldn't you symlink it to the HOME dir?

/home/redmine/.subversion is symlinked to /home/redmine/data/.subversion https://github.com/sameersbn/docker-redmine/blob/master/assets/setup/install#L23-L24

And .ssh is still more essential for me...

I will symlink .ssh directory the similar way.

from docker-redmine.

@sameersbn Thanks! That would help a lot!

You don't want to make it more generalized with ENV variable?

from docker-redmine.

@b-a-t Its a little difficult to explain to users about setting up dotfiles folder, etc than just telling them to edit the existing .ssh or .subversion directory as they see fit. At the same time, these directories need to have the correct ownership or permissions. For example, the .ssh directory needs to have mode 700 and the id_rsa* files need to have 600 permissions. So things like this need to be setup correctly.

One change I am considering making is install these directories in a directory named dotfiles inside the data dir so that all these files are grouped within one single directory.

regarding adding ENV variable to specify use of dotfiles is not required. Users who need to configure the dotfile can do so. Others will just ignore them.

from docker-redmine.

@b-a-t I have moved the .ssh and .subversion directories to dotfiles directory. Also I have added generation of ssh keys for the redmine user if they do not exist which the users can change if they desire.

from docker-redmine.

@sameersbn Just want to say Thank you!. Works like a charm!

from docker-redmine.