Git Product home page Git Product logo

Comments (11)

jcormier avatar jcormier commented on June 27, 2024 1

Thanks for the bump, this has been dragging for quite a while. I'm still fairly swamped at work currently.

I merged the ruby changes into master, and tagged 5.1.1-4. Docker images are building now.

from docker-redmine.

CSCSxx avatar CSCSxx commented on June 27, 2024

Hello, I use your Dockerfile in a Synology Nas via the integrated Docker Manager.
The current version 5.0.7-1 still uses the old Ruby interpreter in version 2.7.5 (version 2.7.8 would be the last in this series and this is already EOL!)
2.7 is specified in the variable list - if I change this value to 3.0 even before starting the container for the first time, the 2.7 version will continue to be used - how can I change this using board resources?
Thanks for your support

from docker-redmine.

outductor avatar outductor commented on June 27, 2024

@CSCSxx You should make your own issue... that's not what we discuss in this issue

from docker-redmine.

jcormier avatar jcormier commented on June 27, 2024

According to your title, your both requesting a newer version of Ruby. Unfortunately, 2.7 is the newest version of ruby in the brightbox/ruby-ng repo. Which means bumping the OS version, which cascades into a lot of other changes.

I will try to bump it again, but it might turn into a project.

from docker-redmine.

jcormier avatar jcormier commented on June 27, 2024

Alright, this took way too long but I pushed a new branch, ruby3.2 that moves the 5.1.1 redmine to ruby 3.2. This ended up involving swapping to a Debian-based distro. So it would be good if people would try it out and see if it works before I merge it into master.

I don't know anything about YJIT, does redmine support it? How do you even enable it?

from docker-redmine.

outductor avatar outductor commented on June 27, 2024

https://shopify.engineering/ruby-yjit-is-production-ready
https://railsatscale.com/2023-09-18-ruby-3-3-s-yjit-runs-shopify-s-production-code-15-faster/

this should be nothing but platform agnostic change, meaning redmine doesn't specifically have to care about it.

In order to turn it on and off, you just need to specify RUBY_YJIT_ENABLE=1 or RUBYOPT=--yjit in your ENV option. I am not saying we should enable YJIT by default, since it's just my preference and motivation of adopting Ruby 3.2.

from docker-redmine.

kannrem avatar kannrem commented on June 27, 2024

Alright, this took way too long but I pushed a new branch, ruby3.2 that moves the 5.1.1 redmine to ruby 3.2. This ended up involving swapping to a Debian-based distro. So it would be good if people would try it out and see if it works before I merge it into master.

I don't know anything about YJIT, does redmine support it? How do you even enable it?

We tested the ruby3.2 branch and its working as expected. thanks. Could you please merge to master or create a new image out of it? Also we would like to point out the problem with attachments which will get saved in /redmine/files. this directory is not in sync with mounted volume /data/files. hence the data there are not persisted and attachments are getting lost once the new container brought up.

from docker-redmine.

jcormier avatar jcormier commented on June 27, 2024

Also we would like to point out the problem with attachments which will get saved in /redmine/files. this directory is not in sync with mounted volume /data/files. hence the data there are not persisted and attachments are getting lost once the new container brought up.

eh? thats a huge problem. Though neither of those paths exist I'm going to assume your paraphrasing...

from docker-redmine.

jcormier avatar jcormier commented on June 27, 2024

Also we would like to point out the problem with attachments which will get saved in /redmine/files. this directory is not in sync with mounted volume /data/files. hence the data there are not persisted and attachments are getting lost once the new container brought up.

So not sure what you mean, I just tested in the master branch and files were correctly persisted.

root@5d231c2e4892:/home/redmine/redmine# ls /home/redmine/data/files/2024/01/2401152042*
/home/redmine/data/files/2024/01/240115204204_6252_23026330_bootlog.txt
/home/redmine/data/files/2024/01/240115204216_am62a7_evm_edgeai_09_00_01_08.log
$ ls -l /srv/docker/redmine/redmine/files/2024/01/2401152042*
-rw-r--r-- 1 jcormier-local jcormier-local  42449 Jan 15 10:12 /srv/docker/redmine/redmine/files/2024/01/240115204204_6252_23026330_bootlog.txt
-rw-r--r-- 1 jcormier-local jcormier-local 363980 Jan 15 10:12 /srv/docker/redmine/redmine/files/2024/01/240115204216_am62a7_evm_edgeai_09_00_01_08.log

I also tested it on the ruby3.2 branch and had no issue with files persisting.

from docker-redmine.

kannrem avatar kannrem commented on June 27, 2024

Also we would like to point out the problem with attachments which will get saved in /redmine/files. this directory is not in sync with mounted volume /data/files. hence the data there are not persisted and attachments are getting lost once the new container brought up.

So not sure what you mean, I just tested in the master branch and files were correctly persisted.

root@5d231c2e4892:/home/redmine/redmine# ls /home/redmine/data/files/2024/01/2401152042*
/home/redmine/data/files/2024/01/240115204204_6252_23026330_bootlog.txt
/home/redmine/data/files/2024/01/240115204216_am62a7_evm_edgeai_09_00_01_08.log
$ ls -l /srv/docker/redmine/redmine/files/2024/01/2401152042*
-rw-r--r-- 1 jcormier-local jcormier-local  42449 Jan 15 10:12 /srv/docker/redmine/redmine/files/2024/01/240115204204_6252_23026330_bootlog.txt
-rw-r--r-- 1 jcormier-local jcormier-local 363980 Jan 15 10:12 /srv/docker/redmine/redmine/files/2024/01/240115204216_am62a7_evm_edgeai_09_00_01_08.log

I also tested it on the ruby3.2 branch and had no issue with files persisting.

sorry, my bad! i was expecting the attachment data to be in REDMINE_ROOT/files directory(/home/redmine/redmine/files). that is where our existing redmine stores the files. but things are clear now . thank you!

from docker-redmine.

kannrem avatar kannrem commented on June 27, 2024

@jcormier Thankyou for ruby support as most of the plugins we tried requires ruby 3.x. Could you please merge this branch to master or would you be able to push a seperate image with ruby tag. Thankyou

from docker-redmine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.