Git Product home page Git Product logo

Comments (7)

sameersbn avatar sameersbn commented on July 21, 2024

@b-a-t I am not sure about adding man command in the container. Technically the user is not expected to do anything with the container other than just deploy redmine.

I never paid any attention to the manpages / docs that packages installed. If removing them proves to be a huge space saver then maybe I will remove them. If the difference is negligible then I will not bother removing them.

On the other hand if installing man-db package does not make much of a difference on the image size then maybe I will consider adding it. However I don't feel very comfortable doing so.

edit: And yes adding man-db to the base image makes more sense then adding them here.

from docker-redmine.

b-a-t avatar b-a-t commented on July 21, 2024

I understand. I'm not sure which path is better either. In pro-man argument I can add that when I needed to look for the syntax of bzr for redmine setup(which I don't use and don't have installed system-wide) the handiest option was to see it within a container.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@b-a-t I understand.. I'll take a call on this as soon as I can see what difference it makes on the image size.

from docker-redmine.

majkinetor avatar majkinetor commented on July 21, 2024

I think container shouldn't have anything that is not needed to run it. There are other options if you want to customize the images. For fast things like adding man pages you could also add it to the init script which is used to init plugins.

You can test it up using my automated installer, see: https://github.com/majkinetor/redserver. If you use it, you can change redserver ansible provisioner to add desired stuff to the server once, not the container. See base role for that.

@sameersbn, My installer also contains updated version of plugin downloader script which contains a lot less repetition.

from docker-redmine.

b-a-t avatar b-a-t commented on July 21, 2024

Well, my point is - we install manpages anyhow, so should take one step farther in one of the directions - if we want to be conservative on a disk space, then should delete them all or, we may install man-db and be able eventually actually read those manpages.
Personally, for me ability to read those manpages was useful, while I was hacking around the image.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@b-a-t removing the existing man pages in /usr/share/man does not have any effect on the final size of the image. For my gitlab image, the size of /usr/share/man directory is ~9M. Out of this ~7M comes from the base ubuntu image. Deleting the contents of /usr/share/man in higher layers does not reflect in the final image size because physically these files exist.

This leaves us with the option of either installing the man package or leave the image as is. I prefer the later even though installing the man package only increases the image size by ~5M.

from docker-redmine.

mc0e avatar mc0e commented on July 21, 2024

I don't think you should install user tools. It's trivial for people to base an image on yours and add stuff if they want it, or to look at the man pages in another environment.

from docker-redmine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.