Git Product home page Git Product logo

Comments (26)

sameersbn avatar sameersbn commented on July 21, 2024

@gionn at the moment there there is no support for hosting git repositories within the image. If you can point me to a plugin that does this and is well maintained, i would be interested in checking it out.

Please take a look at my docker-gitlab image which packages the gitlab code hosting application. If you try gitlab, you will love it. I GUARANTEE 👍

from docker-redmine.

gionn avatar gionn commented on July 21, 2024

I like Gitlab too and I would like to migrate immediately, unluckily I need to stick with redmine in our company for a while.

A supported and maintained plugin seems https://github.com/jbox-web/redmine_git_hosting, if you are busy I can try to put it one of these nights and push a PR.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@gionn over the weekend I plan on putting together some stuff to enable users to install plugins. Maybe we can wait till then.

from docker-redmine.

gionn avatar gionn commented on July 21, 2024

I don't know what you are planning to implement, but the redmine_git_hosting plugin needs some additional configurations apart from installing the plugin (https://jbox-web.github.io/redmine_git_hosting/howtos/index.html), so it may not be so straight-forward.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@gionn yes.. I gathered that after seeing the installation guide of redmine_git.

I think it might not be such a good idea to install redmine_git in this image. Reason being that some users are using redmine for issue tracking while using gitlab for code hosting. In which case, adding redmine_git would increase the resource utilization.

I propose, that either we add redmine_git functionality in a branch and build the branch as a different image. But maintaining this might turn out to be difficult. Additionally, the trusted build service does not allow adding the same repo twice.

The alternate solution is to create a new repo which inherits this image. Something on the lines of

FROM sameersbn/redmine:2.5.2
ADD install /app/install
RUN /app/install

As long as the /app/init script is not overwritten, all the functionality/options of the base image will remain. If at all the init script needs to be updated, then I can add some functionality in the redmine image to source a script into the main init script.

You can either create the new image or send me a PR against this image, and I will use it as a base for the new image and make the required changes.

The last option is to fork the image.

from docker-redmine.

gionn avatar gionn commented on July 21, 2024

I think the proper docker way to handle this situation is to build a new image based on this one.

Having an hook at the end of init script would be a plus (e.g: if init.custom exist, execute it).

I will create a new repository and in case I need something, I will send a PR :)

Thanks for your prompt support.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@gionn sounds good!
Looking forward to try out the finished image.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@gionn I just had an epiphany.
Technically if you use gitlab for the code hosting and repository management. Running redmine with the --volumes-from gitlab docker option would make all your gitlab repositories available in redmine.

I should probably try this out.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

works swimmingly!

redmine-gitlab

from docker-redmine.

gionn avatar gionn commented on July 21, 2024

This is just an epic resolution, I would love to get rid of that, I will give it a try!

Thanks for the suggestion.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

sameersbn/docker-gitlab@a8b4a14

from docker-redmine.

gionn avatar gionn commented on July 21, 2024

@sameersbn I've played a little with those new toys, the unique problem I've found is the uid mismatch between gitlab-created repositories (1000:1000 with rwxrws---) and the uid used by redmine (www-data).

How have you handled it?

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@gionn please use the latest tag. Sorry for not mentioning that. In the latest tag the uid's will be the same. I am supposed to make a point release soon. Just need to get some changes in first.

from docker-redmine.

kopax avatar kopax commented on July 21, 2024

@sameersbn

Technically if you use gitlab for the code hosting and repository management. Running redmine with the --volumes-from gitlab docker option would make all your gitlab repositories available in redmine.

I have just tried, I have nothing.
I've also connected and check for the presence of /home/git/data and it is here.

Do I have anything more to setup ?

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@kopax it will only make the repositories directory available on the redmine container. You still need to manually add the repository path in your projects.

from docker-redmine.

kopax avatar kopax commented on July 21, 2024

@sameersbn ok

I have just added an existing repository, when i go on /redmine/projects/test/repository

The entry or revision was not found in the repository.

Do I have anything else to setup ?

from docker-redmine.

agustisanchez avatar agustisanchez commented on July 21, 2024

I found the same problem (entry or revision not found) when mounting a volume containing Git repos. I docker ssh into the running redmine container and I can see the repos but get the aforementioned error when referencing the repo in Redmine UI.

from docker-redmine.

agustisanchez avatar agustisanchez commented on July 21, 2024

Same problem if the Git repo is created inside the redmine container in a regular directory.

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@agustisanchez The redmine user (uid: 1000) needs to have the required permissions to the git repos. There are two ways to solve this

  1. Use the USERMAP_ options to map the redmine user to the UID of the user that owns the git repos.
  2. Create a entrypoint.custom.sh which adds the redmine user to a group that has access to the gire repos.

Refer #123 for some more details.

from docker-redmine.

GordonKiomon avatar GordonKiomon commented on July 21, 2024

@sameersbn are you able to give some detail step for how to link gitlab to redmine? i had a hard time to make it works here, what else configs or settins should i do except --volume-from=gitlab?

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@GordonKiomon it goes without saying that for --volumes-from=gitlab to work, gitlab should also be running in a container.

The --volume-from=gitlab only makes available the /home/git/data volume available in the redmine container at the same path. From that point on everything is a manual process. So if you want a git repository to be browsable from redmine you need to go to project > settings > repositories in redmine and add the path to the git repository which be be located inside /home/git/data/repositories/

from docker-redmine.

GordonKiomon avatar GordonKiomon commented on July 21, 2024

@sameersbn I did start a gitlab container, but do not reallize that i need to manually do the settings, thought there might be some setting or config which could be done in redmine to make it talk with gitlab automatically.
thank you, i will try it out.

from docker-redmine.

GordonKiomon avatar GordonKiomon commented on July 21, 2024

@sameersbn finally made it works, but not convenient to make the git repo work in this way. seems you guys talked about working on a new image with "redmine_git_hosting", any news on that?

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

No. This image will not add any third party plugins. You will need to create a new image which you can base on top of this image to add the redmine_git_hosting plugin.

from docker-redmine.

grahovam avatar grahovam commented on July 21, 2024

I am using both sameers gitlab and redmine image for our project code hosting and management. Since I want the gitlab repos to be visible in redmine, both images have to be on the same host. In addition, I am using jwilder/nginx-proxy so that there is different URLs for gitlab and redmine. But now i read the following article:
https://www.lvh.io/posts/dont-expose-the-docker-socket-not-even-to-a-container.html
It says that exposing the docker socket is a security risk. This makes using jwilder/nginx-proxy a security risk.

Is there another option for having different URLs for redmine and gitlab than using jwilder/nginx-proxy?

from docker-redmine.

sameersbn avatar sameersbn commented on July 21, 2024

@grahovam yes. exposing your docker socket to containers poses a very serious security risk. I have never used the jwilder/nginx-proxy image before, but from the documentation it appears that it automatically updates the nginx vhost configs when containers are started and stopped.

If you wish to get rid of the security implications that exposing the docker socket has, you can create the vhost configs manually without relying on jwilder/nginx-proxy to do them for you. If the jwilder/nginx-proxy doesn't allow you to create vhost configs, then you can switch to some other nginx image that allows you to do so.

from docker-redmine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.