saltyshiomix / gfm-preview Goto Github PK

Newlines do not (and have never) rendered correctly. If there is no full line gap between two paragraphs, the second just continues the first; GFM renders them as a full pressing of enter.

Currently the app assumes that you're using localhost as your hostname. If you try to run it on a remote system, it loads but the HTML fails to pull in it's contents because it assumes everything is localhost. By changing the localhost value to another hostname, I was able to get it to work remotely. I would suggest that you do the same substitution that you do for <!--TITLE--> and allow the hostname to be passed in via the command line

GFM was working fine (sans the rendering bugs), and then I updated my Node, to receive this error:

> gfm-preview: Ready on http://localhost:4649
/usr/local/lib/node_modules/gfm-preview/index.js:157
  watcher.on('change', () => {
          ^

TypeError: Cannot read properties of undefined (reading 'on')
    at Namespace.<anonymous> (/usr/local/lib/node_modules/gfm-preview/index.js:157:11)
    at Namespace.emit (node:events:514:28)
    at Namespace.emit (/usr/local/lib/node_modules/gfm-preview/node_modules/socket.io/lib/namespace.js:219:10)
    at /usr/local/lib/node_modules/gfm-preview/node_modules/socket.io/lib/namespace.js:190:12
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)

Node.js v20.10.0

It now fails to run.

(Hopefully my last request)

If you are in a host that hits github too frequently, you get rate limited. It would be nice to add the ability to set your github credentials. If there set, you can pass the credentials to the axios post like:

const config = {};
if (github_username === undefined) {
    config.auth = {
        username: github_username,
        password: github_password
    }
}
const response = await axios.post(apiUrl + '/markdown', { text, mode: 'gfm' }, config);

If the axios call fails (for my example my IP address what rate limited for an unauthenticated request) no feedback is given. I think the code below should handle that case

try {
      const response = await axios.post(apiUrl + '/markdown', { text, mode: 'gfm' })
      content = response.data
} catch (e) {
      content = e.response.data.message
}