saltedseacorn / assignment-5 Goto Github PK

Hi Kon! Here is your feedback for lesson 5:

Challenge 1:

• There is no prompt to ask user for numbers
• Edge cases and function do operate properly and give correct answers, when numbers are provided in the function call on line 55

Challenge 2:

• arrayOfLetters isn't actually an array, it's a string
• Vowels are always returned first, regardless of user's decision; I tried to figure out where the breakdown was happening, but your code looks right. I think somehow it's something to do with your if-else if-else statement because it did correctly accept what the user entered, but always proceeded to the if portion of the if-else if-else statement, even if what the user entered wasn't vowels or VOWELS. I'll either need more time to dig, or you can check with another mentor if you'd prefer not to wait until I'm available.

Challenge 3:

• At first I thought I was a bad guesser! But I console logged the random number so I would be guaranteed to enter the correct number, and it still said I didn't guess the number. I think it's because you are initializing and assigning gameSetup to the first number the user enters and it never gets updated because line 195 is merely a prompt, but doesn't do anything with the number taken when the user was prompted on attempts 2 +/- 3.
• There is no array of numbers the user attempted
• Since lines 206 and 207 are commented out, no results are displayed on the webpage.
• Even commenting those back in, the endGameMesasge is always "Oh no! You've run out of lives.." so you'll want to walk through your code again and see why the message isn't updating to congratulate/condemn the user's guessing ability.
• Message displayed should either be "Player name, you wasted your three guesses on wrong numbers the user entered here" or "Player name (in all caps) won!"

Challenge 4:

• Forgot to comment back in lines 301 and 302 which give the user their results, but once those were, everything worked perfectly. Good job!

TO DO:

1. Fix challenge 1 to accept user numbers
2. Be sure to make an array of the letters that make up the word the user entered in challenge 2; find and fix the if statement to properly return either vowels first or consonants first
3. Fix line 195, comment back in the results, make sure you're creating an array of the guessed numbers, and find and fix the endGameMessage so it is updated properly depending on if the player won/lost in challenge 3
4. Comment lines back in in challenge 4

Resubmit after making fixes, please. Feel free to reach out if you need help with fixes/finding where the code is breaking/malfunctioning.