salopensource / puppet_checkin_module Goto Github PK

Adding the puppet_checkin_module.py to the checkin_modules folder of a sal-scripts 3 installation, causes an error with sal-submit:

# /usr/local/sal/bin/sal-submit
Traceback (most recent call last):
  File "/usr/local/sal/checkin_modules/puppet_checkin_module.py", line 26, in <module>
    import utils
ImportError: No module named utils

I tried to fix this by making the script use the python3 that's included in sal-scripts 3, and replacing utils.set_checkin_results("Puppet", results) by sal.set_checkin_results('Puppet', results), but that doesn't work, because the yaml module needs to be installed in the python 3 installation that is included in sal-scripts 3. Unfortunately, my python skills are severely lacking, so I don't know how to do that.

Instead I opted to rewrite the puppet_checkin_module.py in ruby (because my ruby skills are somewhat better than my python skills, but also because it allows me to use the ruby interpreter that comes with puppet, and takes makes parsing the last_run_report.yaml easier). That works perfectly fine (although note that you'll also need to 'enable' puppet in server/view.py on the server).

I'm not sure if it's useful to swap puppet_checkin_module.py with my ruby script, because it will probably hurt maintainability of the sal project by adding one ruby script when the rest of sal is python. But I can upload it if you're interested.