Git Product home page Git Product logo

spellchecker's People

Contributors

sallasal avatar

Watchers

 avatar

spellchecker's Issues

Peer review ("Vertaisarviointi")

The project was cloned: 22.4.2021 18:48

Peer review I

First of all, I have to say that your project is unbeliveable! The documentation is so clear and wide that it feels so professional! The code is pure and I can't find anything really worth of telling. Well, something is required so here is some minor things that you perhaps see worth of thinking!

  • Those 15,000 words are quite plenty but could it be more? I don't really know if this has any impact to your project but perhaps a larger collection could serve you more?

  • I see that there are more comments and javadoc in the SpellChecker than in the TrainSpellChecker. If this is a part of the final project remember to add those as well! Just like in the SpellChecker (really nicely done!). Same thing about tests etc.

  • Hmm, perhaps the lines in the code could be divided when those go over the prefered length? For example, Netbeans suggests that by white/grey line how long it should be.

  • Is there going to be tests for dao and ui as well? There is now tests only for domain. Maybe those are quite useless but maybe worth of something!

I really can't wait to see your demo and the project functioning when fully ready!

Vertaisarviointi

Kloonattu 30.4. klo 22:30.

Tosi hyvä työ on tehty. Projekti on hyvä kokonaisuus ja aihe on valittu hyvin.
Kodi on hyvin jaettu, helppo lukea ja nimikkeitä ovat kunnossa.
Dokumentaatio on täydellinen, se avaa aiheen, prosessin ja anna selkeät ohjeet asennukseen.
Testejä on myös tehty.

Repository on siisti, gitin viestit kertovat hyvin sisällöstä, linkit kotisivulla.

Voitko tässä vaiheessa tehdä releasin? Jos työ on valmis, niin eikö nyt ole hyvä hetki? :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.