salesking / king_dtaus Goto Github PK

We are doing bank transfers to the USA, where the DTAZV format is needed. Transfers are done via routing number and BIC codes. A U.S. bank routing number is 9 digits, while KingDta::Account accepts 8 digits only.

I would fix this myself, but are not sure, which would be the best option.

• Option A: Subclass KingDta::Account to a KingDta::DtazvAccount where longer bank_numbers and bank_account_numbers are allowed.
• Option B: Move the length check to KingDta::Dtaus, so that the allowed length is checked depending on the format (DTAZV allows longer numbers than DTAUS).

Any suggestions?

the URL dev.blog.salesking.eu/... is no longer valid, I think it should read: https://www.salesking.eu/blog/coding/kingdtaus-gem-dta-gutschriften-und-lastschriften-in-ruby-erzeugen/

Hello,

we are having a use case where the creation date is different from the execution date.

I have already a fix to use a variable for this:

https://github.com/salesking/king_dtaus/blob/master/lib/king_dta/dtaus.rb#L80

 data += '%8s' % @execution_date.strftime("%d%m%Y")

If you want I can issue a PR.

Thanks for your attention!

Patrick

We would like to use the feature in this commit b68a3a3 but there has been no gem release yet where it is included. Can you release a new gem version soon?

Hej folks,

it looks like there's been done some work since the last 2.0.4 release -> 44d5549...master

what do you think of making a new release? sure i can reference master ... but that always feels so off :)