System Frame flags not working about sampleanalyzer HOT 3 OPEN

The Logic software does not look at mFlags - it's setup as a convention for analyzers to implement in GenerateBubbleText.

example:

if( frame.mFlags & DISPLAY_AS_ERROR_FLAG )
{
	AddResultString( "!Warning: MAB is too short" );
}

Unfortunately the analyzer SDK does not support emojis, and I suspect that it doesn't handle anything other than vanilla ascii. If I have time I'll check into that to see if there is an easy fix. I know the software supports displaying ⚠ and the round trip between an std::string / QString and the display, so we must be making a mistake somewhere in the analyzer results system - we might be passing it to QString incorrectly, for instance.

from sampleanalyzer.

From the documentation: "Two flags are reserved by the system, and will produce an error or warning indication on the bubble displaying the Frame.". Proceeding from this, you conclude that the processing of system flags should be performed by the main program, and processing of custom flags should be handled by the plug-in function GenerateBubbleText. Why in this case the reservation of system flags and their announcement in SDK? In my understanding, this should affect the color of Bubble messages, for example.

from sampleanalyzer.

Thanks for pointing this out, we desperately need to update the documentation for this.

I think when that comment was added, we did plan to do something with mFlags. However, I can confirm that we never implemented a feature that uses it. We also won't be adding this in the future. Many of our analyzers and 3rd party ones use mFlags for analyzer-specific information, so the software can't make any assumptions about what will be found there.

Unfortunately I don't know when we'll have the time - we're a tiny team at the moment, and we're focused mostly on real time view and other feature improvements. We are also working on a system for unit testing protocol analyzers though, which we will open source. (technically it's public at the moment, but it's still in the early stages)

from sampleanalyzer.