Git Product home page Git Product logo

Comments (5)

antoineco avatar antoineco commented on June 11, 2024 1

It looks simple enough 👍 We would do exactly the same as they suggest: link both groups.

from sonokai.

antoineco avatar antoineco commented on June 11, 2024 1

That is very likely. We did not link this highlight group explicitly, so if both Neo-tree and nvim-tree pick different values, they will look different in both plugins.

Any other difference you think we should address?

from sonokai.

antoineco avatar antoineco commented on June 11, 2024

I just noticed that we already have a few highlight groups for Neo-tree since b2199f4, so if they don't work, it means that they are probably outdated:

sonokai/colors/sonokai.vim

Lines 1446 to 1466 in c995ad5

" syn_begin: neo-tree {{{
" https://github.com/nvim-neo-tree/neo-tree.nvim
if !s:configuration.transparent_background
call sonokai#highlight('NeoTreeNormal', s:palette.fg, s:palette.bg_dim)
call sonokai#highlight('NeoTreeEndOfBuffer', s:palette.bg_dim, s:palette.bg_dim)
call sonokai#highlight('NeoTreeVertSplit', s:palette.bg0, s:palette.bg0)
endif
highlight! link NeoTreeGitAdded Green
highlight! link NeoTreeGitConflict Yellow
highlight! link NeoTreeGitDeleted Red
highlight! link NeoTreeGitIgnored Grey
highlight! link NeoTreeGitModified Blue
highlight! link NeoTreeGitUnstaged Purple
highlight! link NeoTreeGitUntracked Fg
highlight! link NeoTreeGitStaged Purple
highlight! link NeoTreeDimText Grey
highlight! link NeoTreeIndentMarker NonText
highlight! link NeoTreeNormalNC NeoTreeNormal
highlight! link NeoTreeSignColumn NeoTreeNormal
highlight! link NeoTreeRootName Title
" syn_end }}}

Ref.

from sonokai.

kaykhan avatar kaykhan commented on June 11, 2024

Interesting i just know that the color of the folder icon did not match what i had in nvim-tree. https://github.com/nvim-neo-tree/neo-tree.nvim/blob/v2.x/doc/neo-tree.txt#L1154

from sonokai.

kaykhan avatar kaykhan commented on June 11, 2024

That is very likely. We did not link this highlight group explicitly, so if both Neo-tree and nvim-tree pick different values, they will look different in both plugins.

Any other difference you think we should address?

Not that i can think of

from sonokai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.