Comments (9)
Strange, we fixed that in #67. Maybe something changed in LSP Saga since that fix.
from sonokai.
Yes, and ported to all sainnhe's color schemes as soon as I test the potential fix locally.
from sonokai.
That looks like a bug to me, see the following issue for the expected rendering of LSP Saga's pop-ups: sainnhe/everforest#88
You closed the issue almost immediately after opening it, does it mean you found a solution? If yes, could you please share your findings?
from sonokai.
@antoineco My issue was completely different and i resolved it on my own.
But i realised what i had shown does resemble that issue in the referenced issue on everforest.
I was able to replicate that problem on sonokai.
from sonokai.
OK looks like there were indeed a couple of breaking changes introduced in LSP Saga, and there is now a single highlight group for all diagnostic borders: https://github.com/glepnir/lspsaga.nvim/blob/44af2ab1/lua/lspsaga/highlight.lua#L60
Ref. nvimdev/lspsaga.nvim#586 (highlight.lua
)
from sonokai.
OK looks like there were indeed a couple of breaking changes introduced in LSP Saga, and there is now a single highlight group for all diagnostic borders: https://github.com/glepnir/lspsaga.nvim/blob/44af2ab1/lua/lspsaga/highlight.lua#L60
Ref. glepnir/lspsaga.nvim#586 (
highlight.lua
)
Will there be a fix made in this theme to support this change?
from sonokai.
I just looked into this issue and things are a bit more granular than I though.
By default, LSP Saga has the option diagnostic.border_follow
set to true
. In this configuration, the borders of all diagnostic pop-ups are rendered with the highlight group of the corresponding diagnostic type.
For example, a Hint pop-up is created with a border which highlight group is linked to DiagnosticHint
. If I re-link DiagnosticHint
to Green
, the border changes as follows:
This is bad for two reasons:
- LSP Saga hijacks highlight groups related to text for graphics.
- We render
DiagnosticHint
, etc. with undercurl to emulate the style adopted by most IDEs to highlight code related to a diagnostic.
Before, we could get away with setting LspSagaDiagnosticHint
, etc. to a non-undercurl style. Since the recent changes in LSP Saga, it is no longer possible to customize LSP Saga specifically. In my opinion this is a regression, and plugins should under no circumstances expect to be customized only through Vim's internal highlight groups, especially to render graphical elements.
Some plugins—like lualine for example—are graceful enough to allow the user to customize fallback groups. LSP Saga could adopt a similar approach and use DiagnosticHint
by default, while honoring LspSagaDiagnosticHint
if it exists.
We are most definitely not going to override internal highlight groups to accommodate one specific plugin, so unless the author of LSP Saga changes their approach to border rendering, LSP Saga won't be supported in Sonokai / Gruvbox material / Everforest / Edge moving forward.
from sonokai.
Okay i appreciate the effort looking into this. Maybe its something to bring up to the maintainer of LSPSaga.
from sonokai.
Cross referencing sainnhe/everforest#136 (same root cause)
from sonokai.
Related Issues (20)
- A lot of highlight warning. HOT 2
- How to change style to Andromeda in lua? HOT 2
- Emacs Port? HOT 4
- bufferline HOT 3
- Can't have transparent background Everywhere HOT 3
- How to set Espresso mode? HOT 2
- Nvim-navic has wrong background color in statusline from lualine HOT 5
- Interest in support nvim lsp semantic highlighting? HOT 6
- Support Neo-tree.nvim HOT 5
- help with folke/noice.nvim and mini view HOT 5
- Configuration for dim float window style HOT 2
- Questions: Better way to highlight variable with {} in shell script HOT 1
- Question: Better highlighter command support for Dockerfile with treesitter HOT 6
- Support vim HOT 3
- Variables starting with uppercase letter have different color HOT 4
- Add support for NotifyBackground HOT 1
- Would you be interested in a PR for a new palette? HOT 4
- Is there a way to toggle the transparency setting at runtime? HOT 7
- xresources, base16-snazy HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonokai.