sahlberg / libsmb2 Goto Github PK

There appears no function in libsmb2 to get/set ACL. Can this be added?

Hi,

Xcode says I have a 16 bytes leak by malloc and traces to smb2_set_password function.

Hi,

can I use libsmb2 to query a server for the different shares (and other services).
I've tried to use smb2_connect_async to connect to a server and then call smb2_opendir_async with directory "/", but it hangs. (I've modified the example smb2_ls_async).

Thanks in advance,
Stef

Hi,

Thanks for fast implementation of statvfs(), Here are two issues I found

1. An strange behavior in linux I found when I implemented apple/swift-corelibs-foundation#1250 was statvfs() populates f_frsize in Linux with correct block size, whereas old-school statfs() (in Darwin) function populates f_bsize! I suggest you to fill both with same value for the sake of compatibility.

2. f_blocks and a_bavail are set to UINT64_MAX when server doesn't command. Is this expected behavior?

smb2_lseek returns -EINVAL on error, else the resulting offset. But if the seek is past 31 bits, then the return value flips negative as it overflows an int. While the seek was good, an error will be signaled (neg return value) and a seek failure will result on app side.

1. Either make current_offset pointer parameter mandatory and only return status ( -EINVAL or 0)
2. Or change the return from int to int64_t, this will not match file->offset (uint64_t) but it has to be signed to signal an error. 1) seems better.

in "libsmb2.c" I can see we set the "ent->dirent.st.smb2_nlink = 0;", is this a limitation? I though this might help to get child file count of a directory, but now I can only get a "0"

When smb2_service() encounters error (say socket error), does libsmb2 issues callbacks to the pending async calls? It looks the code does not do so (smb2_service() simply returns error).

In such case, how would caller do clean up work? Say caller has an open file handle. It can call smb2_destroy_context() to destroy the smb2_context but what about the open file handle? How to free the handle? Should it call smb2_close? But the context is already in bad state. And there is no API to directly close the file handle. This seems like a potential source of memory leak.

Hi

Current implementation does not support FSCTL commands. We need it for two main purposes:

1. Enumerating shares: while I successfully implemented listing shares using file interface, official way to support this capability is to use FSCTL_PIPE_TRANSCEIVE (0x0011c017) command.

   • Listing shares on macOS 10.13 SMB3 server throws Failure to add signature error, similiar to #46.

2. Server-side copy: Currently we have to download then upload data to copy a file. With FSCTL_SRV_COPYCHUNK & FSCTL_SRV_COPYCHUNK_WRITE commands we can duplicate folder/file on server without roundtrip see details.

The port to use is hardwired in socket.cc to be CIFS_PORT (445).
In order to support a server accessed through an SSH tunnel, I'd like
to be able to specify a port for the SMB server.

Would you be willing to accept a code change to accept an optional :port suffix
after the host name?

Hi,

How can I get file_id from smb2fh to pass to smb2_ioctl_request struct?

What is your process/policy for cutting a new release of libsmb2?
Would you accept a request to cut a minor release soon?
I'm interested in getting recent changes into a release so that they can
be picked up by videolan.
Thanks for your help!

Greetings Ronnie!

I randomly found this library from discussions on the libdsm repo about SMB client libraries that support version 2 and up. This library looks absolutely fantastic!

I've been working on an app for iPhone and iPad and one of my dream features is adding SMB2 support so I can easily access files on my NAS over WiFi directly from the device. I wrote a wrapper around libdsm so it could be built and deployed on iOS devices, however libdsm only supports SMB1 at the moment, and given how different the two protocol standards are, I'm not sure if libdsm will ever get SMB2 support.

I'm curious to try building and deploying libsmb2 for iOS, but before that, I thought I'd better ask you.

While being able to dynamically link frameworks on iOS solves most of the conditions of the LGPL, the fact that customers can't easily replace the dynamic framework on their devices themselves means shipping LGPL software on the iOS App Store is still somewhat ambiguous. From what I've seen, it usually depends on the original author's views of the LGPL.

What would your thoughts be on this? Would it be acceptable to use this library in shipping iOS software? Or would you prefer not?

Thanks for your time!

Hi,

I am trying to add a timeout for one of the library functions in libsmb2 but have been unable to find an implementation within the library. I am also using the libnfs library and found a way to timeout a call here. Does some sort of timeout system exist within libsmb2 and if so, does it follow a similar pattern?

Thanks!

smb2_share_enum_async returns Error -22 (Invalid argument) against an macOS SMB Server (10.13.6). It works fine with any other samba server I tested. All other operations (connect, dirlisting) work fine with the macOS SMB server. After some further investigation this issue seems to be related by dcerpc decoding not working for dcerpc responses delivered in multiple fragments.

1. My samba test server returns the dceprc response in one fragement => decoding works fine
2. The macOS SMB Server returns the dcerpc response in multiple fragments with a maximum fragment size of 256 bytes => decoding fails

I have not a full overview how libsmb2 internals work yet, but I assume the fragments (if they are multiple) need to be assembled before decoding, which is currently missing or buggy.
I attached a Wireshark trace for the NetShareEnumAll session against the macOS SMB Server
NetShareEnumAll_macOSHighSierra.pcapng.zip

If I can assist any further, please let me know.

I'm trying to use the examples to make sure the code works properly but I can't seem to connect to my share

$ ./smb2-ls-sync smb://192.168.1.106/concerts/
smb2_connect_share failed. gss_init_sec_context: (Unspecified GSS failure.  Minor code may provide more information,  SPNEGO cannot find mechanisms to negotiate)

I'm just trying to use anonymous guest but I'm not sure about the url
I've tried a bunch of various urls with no success

smb://Guest:@192.168.1.106/concerts/
smb://guest:@192.168.1.106/concerts/
smb://192.168.1.106/concerts/

Any ideas about what I'm doing wrong would be great

It looks like we have the following code for file open:

    /* Create disposition */
    if (flags & O_CREAT) {
            if (flags & O_EXCL) {
                    create_disposition = SMB2_FILE_CREATE;
            } else {
                    create_disposition = SMB2_FILE_OVERWRITE_IF;
            }
    } else {
            if (flags & (O_WRONLY | O_RDWR)) {
                    create_disposition = SMB2_FILE_OVERWRITE;
            } else {
                    create_disposition = SMB2_FILE_OPEN;
            }
    }

This is a bug as it causes all writes to truncate files.

O_WRONLY | O_RDWR should be O_TRUNC

Has Guest access been verified for smb2/3 (built with --without-libkrb5) ?

Seeing failure to connect and just starting to dig into it.

The same url (e.g. smb://timecapsule/) doesn't work in libsmb2 while it works correctly in Samba library when using mDNS. In libsmb2 only smb://timecapsule.local/ URL is working, which results in problems with porting from Samba to libsmb2.

Smb2_parse_url parse has a bug, when there is no domain in url bug path has ';' or '@',

"smb2_parse_url" should first extract the smb:// to the path between smb://domain;user:ip/path, and then analyze the domain and user pwd and ip.

struct smb2_url *smb2_parse_url(struct smb2_context *smb2, const char *url)
{
struct smb2_url *u;
char *ptr, *tmp, str[MAX_URL_SIZE];
char *args;

    if (strncmp(url, "smb://", 6)) {
            smb2_set_error(smb2, "URL does not start with 'smb://'");
            return NULL;
    }
    if (strlen(url + 6) >= MAX_URL_SIZE) {
            smb2_set_error(smb2, "URL is too long");
            return NULL;
    }
strncpy(str, url + 6, MAX_URL_SIZE);

    args = strchr(str, '?');
    if (args) {
            *(args++) = '\0';
            if (smb2_parse_args(smb2, args) != 0) {
                    return NULL;
            }
    }

    u = malloc(sizeof(struct smb2_url));
    if (u == NULL) {
            smb2_set_error(smb2, "Failed to allocate smb2_url");
            return NULL;
    }
    memset(u, 0, sizeof(struct smb2_url));

    ptr = str;

    /* domain */
    if ((tmp = strchr(ptr, ';')) != NULL) {  //this will be bug when path is smb://192.168.1.200/path/1;abc.txt
            *(tmp++) = '\0';
            u->domain = strdup(ptr);
            ptr = tmp;
    }
    /* user */
    if ((tmp = strchr(ptr, '@')) != NULL) { // the same bug like above.
            *(tmp++) = '\0';
            u->user = strdup(ptr);
            ptr = tmp;
}
    /* server */
    if ((tmp = strchr(ptr, '/')) != NULL) {
            *(tmp++) = '\0';
            u->server = strdup(ptr);
            ptr = tmp;
    }

    /* Do we just have a share or do we have both a share and an object */
    tmp = strchr(ptr, '/');
    
    /* We only have a share */
    if (tmp == NULL) {
            u->share = strdup(ptr);
            return u;
    }

    /* we have both share and object path */
    *(tmp++) = '\0';
    u->share = strdup(ptr);
    u->path = strdup(tmp);

    return u;

}

Greetings,
There are some use after free / double frees in the libsmb2 library.
I have forgotten some of them, but this one has been the primary one to cause me the trouble:

dcerpc.c --

dcerpc_decode_pdu:
default: smb2_set_error(ctx->smb2, "DCERPC No decoder for PDU type %d", pdu->hdr.PTYPE); dcerpc_free_pdu(ctx, pdu); // pdu is freed once here, and returns -1 return -1; }

dcerpc_call_cb:

ret = dcerpc_decode_pdu(dce, pdu, &iov);
        if (ret < 0) { // if ret == -1
                pdu->cb(dce, -EINVAL, NULL, pdu->cb_data);
                smb2_free_data(dce->smb2, rep->output);
                dcerpc_free_pdu(dce, pdu); // pdu is freed twice
                return;
        }
        smb2_free_data(dce->smb2, rep->output);

        if (pdu->hdr.PTYPE != PDU_TYPE_RESPONSE) {
                smb2_set_error(dce->smb2, "DCERPC response was not a RESPONSE");
                pdu->cb(dce, -EINVAL, NULL, pdu->cb_data);
                dcerpc_free_pdu(dce, pdu);
                return;
        }

Currently there is no support to add backup intent flag in SMB2 CREATE request.

Wonder what is the right way to do this? Add an extra API to set some flag in smb2_context?

Having the following issue compiling with C++

In file included from /home/lukas/Documents/git/vfs.smb/src/SMBFile.cpp:30:0:
/usr/local/include/smb2/libsmb2-raw.h:32:20: error: uninitialized const ‘compound_file_id’ [-fpermissive]
 const smb2_file_id compound_file_id;
                    ^
In file included from /home/lukas/Documents/git/vfs.smb/src/SMBConnection.cpp:27:0:
/usr/local/include/smb2/libsmb2-raw.h:32:20: error: uninitialized const ‘compound_file_id’ [-fpermissive]
 const smb2_file_id compound_file_id;
                    ^

I can fix the error with the following, but not sure what a proper fix would be

const smb2_file_id compound_file_id = {0};

Looks like this line https://github.com/sahlberg/libsmb2/blob/master/lib/smb2-cmd-error.c#L77 causes an overlapping the body with next header in handling compounded response with errors. while the expected size of response is 9 it actual size is 8. this causes an overlapping the body to next header. this makes unimpossible to use the same context to any other requests.

if I comment this line all works fine

Hi,

Is it safe to use smb2_context in multiple concurrent threads in order to execute file operation functions? What about smb2fh and smb2dir?

In other words, is it safe to call 2 different functions on same context from two different threads?

Hello, thank you for providing the clean smbV2 library, but how can I connect a shared folder without a password and user? Thank you

Currently in smb2-errors.h, there are only a few NT error status codes defined. A more complete status codes can be found at https://msdn.microsoft.com/en-us/library/ee441884.aspx.

I'm having an issue with this include

/usr/local/include/smb2/smb2.h:22:25: fatal error: smb2-errors.h: No such file or directory
compilation terminated.
In file included from /home/lukas/Documents/git/vfs.smb/src/SMBConnection.cpp:25:0:
/usr/local/include/smb2/smb2.h:22:25: fatal error: smb2-errors.h: No such file or directory
compilation terminated.

if I change it to

#include <smb2/smb2-errors.h>

or

#include "smb2-errors.h"

it works

I don't find any symlink create API in libsmb2.h. Is this missing?

I implemented server-side copy using ioctl command. Occasionally smb2_ioctl_reply returned by async handler is corrupted and output_count has weird values like 2939741608. In this condition, when I try to free output memory using smb2_free_data(), I get SIGABRT.

This issue always happens when I try to copy two files simultaneously using same smb2_context.

Unfortunately I can't ignore reply otherwise I will have memory leaks.

Furthermore, reply's ctl_code always mismatch with request's one.

Error is: malloc: *** error for object 0x1c81575f8: pointer being freed was not allocated

libnfs has nfs_truncate

EXTERN int nfs_truncate(struct nfs_context *nfs, const char *path,
                        uint64_t length);

A similar function seems to be missing from libsmb2

Hi,
I'm trying to port libsmb2 to an ESP32. Unfortunately the ESP32 does not support poll() at this time. Although configure checks for HAVE_POLL_H, libsmb2 does not compile without that header file. I think it should be possible to revert to a strictly synchronous API in that case. Any guidance on how to go about that? Simply marking the socket as blocking and doing a no-op in wait_for_reply() doesn't work.
TIA,
AP

if you have a spare time please make it possible to use the same context (i.e. same session) to connect to different trees.

Hi

Documentation states this project dependents on gss-ntlmssp but I could not find how and where. Would you mind clarifying if this library is dependent on that or not?

this works:

smb2_rename_async(smb2, "abc.txt.tmp", "abc.txt", smb2_rename_cb, NULL); // succeed

but the following failed:

// failed with status == -5 in smb2_rename_cb
smb2_rename_async(smb2, "123/abc.txt.tmp", "123/abc.txt", smb2_rename_cb, NULL);

what does the error -5 mean ?

If I read more than 64k bytes from a file (i.e. more than one credit) it causes forcible closing connection by the host on next request.

HI,

When I try to connect to my macOS smb server which is SMB 3.02, All / delimiters in path must be replaced by \ otherwise the operation will fail with Failure to add signature message.

EDIT: This issue is limited to macOS 10.13.4 High Sierra. Windows 10 and Samba on Linux has no issue with dialect 3.02 signing.

We can improve latency by tens of us for busy clients if we try to process as many replies as possible
each time smb2_service() is invoke instead of returning after each pdu.

Encountered this error when using libsmb2 APIs to iterate through a directory tree on an Isilon SMB server. I will attach a tcpdump trace when the problem is happening.

Hi,

How can we list available shares on a server?

Thanks a lot

Hi,

I'm developing a wrapper Swift framework for libsmb2. I successfully have run it on my iOS device but when I try write a file, after opening file with O_WRONLY | O_CREAT | O_TRUNC flag. Either using smb2_write() or smb2_pwrite() I get result -1. I also tried other flags combination for writing.

I've tried to use async version, thus I reimplemented wait_for_reply in Swift. It worked without issue for smb2_rename_async() (as I didn't find sync version).

In async version, smb2_service() returns negative value and smb2_get_error() prints POLLHUP error.

I reiterate this issue is only exist in writing functions and other functions work without any issue.

Thanks for this life saving library by the way. I also wrote building scripts and I can publish framework in Github after this issue got resolved.

EDIT: There is some minor issues in your code in apple platform which I will create a PR later to address them.

EDIT 2: An empty file is created in server every time I execute, if the file does not exist.

I'm not sure if this was intended but it seems that libsmb2 is missing a current_offset argument. This is used by Kodi to get the current position. see, https://github.com/xbmc/xbmc/blob/master/xbmc/filesystem/NFSFile.cpp#L519-L534

libsmb2

int smb2_lseek(struct smb2_context *smb2, struct smb2fh *fh,
               int64_t offset, int whence);

lbnfs

EXTERN int nfs_lseek(struct nfs_context *nfs, struct nfsfh *nfsfh,
                     int64_t offset, int whence, uint64_t *current_offset);

Hi sahlberg
I have been using AMSMB2 which is based on this repo for a long time, it works great, but with the update on Xcode10.2, the list share API failed. I ran the test case of func testShareEnum() of AMSMB2's test case. The case success on xcode10.1 but failed on xcode10.2. After some debug, I found it was caused by smb2_cmd_create_async API.

Can you please take a look? Is it a xcode issue and do we have a workaround?

We currently drop any ACEs we do not understand.
We should probably keep these as-is as blobs so that we will be able to
fetch/mutate-some-aces/store without loss of ACEs.

For the smb2_pwrite_async function, the callback function receives a status of 0 when a write completes successfully instead of the number of bytes written.