saghul / tornaduv Goto Github PK
View Code? Open in Web Editor NEWTornado IOLoop implemented with pyuv
License: MIT License
tornaduv's People
Contributors
Stargazers
Watchers
Forkers
seanjensengrey ayanamist tijmennl alexsnet atvrager v3ss0n mborsuk jaredmessenger xutuke alex8224 kepsic jdavidagudelo michelpogossian yws movermeyertornaduv's Issues
Hello World example doesn't run
The hello-world.py example in the examples directory throws an exception
Traceback (most recent call last):
File "hello-world.py", line 19, in <module>
application.listen(1234)
File "/Library/Python/2.7/site-packages/tornado/web.py", line 1312, in listen
server.listen(port, address)
File "/Library/Python/2.7/site-packages/tornado/netutil.py", line 121, in listen
self.add_sockets(sockets)
File "/Library/Python/2.7/site-packages/tornado/netutil.py", line 133, in add_sockets
self.io_loop = IOLoop.instance()
File "/Library/Python/2.7/site-packages/tornado_pyuv-0.2.1-py2.7.egg/tornado_pyuv/__init__.py", line 59, in instance
IOLoop._instance = IOLoop()
File "/Library/Python/2.7/site-packages/tornado_pyuv-0.2.1-py2.7.egg/tornado_pyuv/__init__.py", line 50, in __init__
self._signal_watcher = pyuv.Signal(self._loop)
RuntimeError: Signal handlers are only supported in the default loop for now
Use the factory interface instead of monkey patching
Tornado has already the functionality to install a custom loop implementation. Instead of patching you should
- subclass
IOLoop - call
IOLoop.configurewith your custom subclass as argument
See: https://github.com/facebook/tornado/blob/master/tornado/util.py#L159
Pass IOLoop.ERROR on error?
I just stumbled across this one: https://github.com/saghul/tornaduv/blob/master/tornaduv/__init__.py#L222
Shouldn't we pass IOLoop.ERROR to the IOStream in this case?
Is this compatible with Tornado 4.x ?
I tested with 3.1 but tests failed. But found out that its at tornado's side. How it is with tornado 4.x?
Also if what are the advantage of pyuv ioloop? speed? more features?
Segfault on Python 3
I'm still getting segfaults on Python 3. No issues with pyuv test suite.
Example stack trace (they vary):
Fatal Python error: Segmentation fault
Current thread 0x00008568:
File ".\tornaduv\__init__.py", line 181 in add_timeout
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\simple_httpclient.py", line 222 in __init__
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\simple_httpclient.py", line 144 in _handle_request
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\simple_httpclient.py", line 139 in _process_queue
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\simple_httpclient.py", line 124 in fetch_impl
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\httpclient.py", line 245 in fetch
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\testing.py", line 372 in fetch
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\test\httpserver_test.py", line 970 in test_large_body_streaming_chunked
File "C:\Users\schlaich\Documents\GitHub\tornaduv\.tox\py33\lib\site-packages\tornado\testing.py", line 118 in __call__
Example exception analysis with WinDbg: https://gist.github.com/schlamar/ef9d2e9e36a903473185
Might be related to https://travis-ci.org/saghul/tornaduv/jobs/43068387
Callbacks should allow *args and **kwargs
There is an API incompatibility, see https://github.com/facebook/tornado/blob/master/tornado/ioloop.py#L611
test_multi_process fails on OSX
I have one failing test case on OSX. AFAIS pyuv/libuv doesn't work with Python's fork, so this might be an upstream bug to one of these projects:
test_multi_process (tornado.test.process_test.ProcessTest) ... The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
This test works with the standard IOLoop on OSX and with UvLoop on Linux/Travis: https://travis-ci.org/schlamar/tornado-pyuv/builds/42473527.
Any idea? :)
Does this solution work fine under Windows platforms?
As we know, the tornado framework do not support the Windows platforms. They do not support epoll. But pyuv support AIO. So how this solution works under Windows platforms?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.