sagebind / atom-gtk-dark-theme Goto Github PK

This happens when you launch an application just after launching atom.

For example, I open atom using atom . and while that is loading and window is still not shown I open pinta (or any other application with a titlebar, you wont be able to see the difference in a header bar window)

Hi there 😺! Your package works great, but when I found it today I was hoping to enlist you in my effort to bring a much cleaner method for enabling the dark theme to Atom.

While I think GTKDarkThemeVariantSetter was a pretty cool hack, it was also an act of desperation because of how limited the Sublime Text API is. When Atom came out, I immediately started to think about how we could do it better this time given that the program is open source. So I filed electron/electron#352, which fortunately was implemented shortly after. Therefore, the great news is that Electron already supports setting the dark theme variant through a BrowserWindow flag!

The last missing puzzle piece is now atom/atom#8287. I have hesitated to file a pull request directly because Atom is now stable which means the API can not be changed randomly anymore, but as soon as BrowserWindow options can be injected by packages, your package could be adapted to use that mechanism, which would work much faster, require no external process invocations, and even work on platforms other than Linux in theory (though I am not aware of any GTK+ ports supporting dark themes). Better yet, we could even push for a (Linux only) switch to be included directly in Atom core that would allow the user to flip from light to dark theme and back whenever they like.

Our best bet right now is probably to lend weight to atom/atom#8287, which, once resolved, will allow us to bring first-class GTK+ theme variant support to Atom.

🌴

Hey, reader! Just a quick PSA from someone in the community, since it seems this repo is now unmaintained.

gtk-dark-theme in Atom.io refers to a different version than what's on GitHub.

The version on master here contains some bug fixes which are not released yet. In particular, #4 is merged, which should fix issue #2! :) To try it out, you'll have to manually bring it into ~/.atom/packages:

cd ~/.atom/packages
git clone https://github.com/sagebind/atom-gtk-dark-theme.git
# Reload Atom after this

When Atom isn't running and I open a file from the system or tmp, Atom loads with the light bar.
When I first open Atom, and then open a file either by double clicking in the file manager or through the Atom menus, the bar is rendered dark a second after loading the light one.
Using Gnome 3.24 on Arch with Wayland.

Hello,
Thank you for your plugin.
It seems it's not working on Arch with gnome 3.22.2 / gtk3-3.22.9.
After activation, I tried to restart atom but nothing changes, it is still white color decorations.
Any ideas ?
Thanks