sadym-chromium / bidiinchromecontext Goto Github PK

It looks like it's being used as a Map, so let's make it one:

When running the tests and expecting them to pass, a headless browser is probably less distracting, so a --headless flag would be nice.

This would make it easier to collaborate by reducing the need to discuss code style etc.

We could use Prettier. Here's Puppeteer's config: https://github.com/puppeteer/puppeteer/blob/main/prettier.config.js

• add LICENSE file (done in #7)
• add license headers

Currently, browser starts when BiDi Server is started. Instead, BiDi Server should run an instance of browser for each WS connection like in this prototype:
https://github.com/sadym-chromium/WebDriverBiDiServerExperiments/blob/b343ffe15966a720f567dad6af6d1ff5cc9ae9b9/bidiServer/server.js#L360-L365

There's currently a lot of output even when not using the DEBUG environment variable. Can this be reduced to just something like "Listening on port 8000" and logging errors? (When running tests, logging only fatal errors, since bad input is deliberately used.)

The webdriver-bidi repo has a GitHub workflow that generates remote and local end definitions files here:
https://github.com/w3c/webdriver-bidi/blob/master/.github/workflows/test.yml. We should investigate using these files to generate typescript classes, and code for validating command parameters.

When running the tests I see this on the console of the server:

Error: @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed?

The whole thing:

(node:62371) UnhandledPromiseRejectionWarning: Error: @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed?
    at error (file:///Users/foolip/src/bidiInChromeContext/node_modules/rollup/dist/es/shared/rollup.js:5226:30)
    at throwPluginError (file:///Users/foolip/src/bidiInChromeContext/node_modules/rollup/dist/es/shared/rollup.js:18005:12)
    at Object.error (file:///Users/foolip/src/bidiInChromeContext/node_modules/rollup/dist/es/shared/rollup.js:18631:20)
    at preflight (/Users/foolip/src/bidiInChromeContext/node_modules/@rollup/plugin-typescript/dist/index.js:476:17)
    at Object.buildStart (/Users/foolip/src/bidiInChromeContext/node_modules/@rollup/plugin-typescript/dist/index.js:716:13)
    at file:///Users/foolip/src/bidiInChromeContext/node_modules/rollup/dist/es/shared/rollup.js:18835:25
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Promise.all (index 0)
    at async rollupInternal (file:///Users/foolip/src/bidiInChromeContext/node_modules/rollup/dist/es/shared/rollup.js:20254:9)
    at async read (file:///Users/foolip/src/bidiInChromeContext/src/.build/mapperReader.js:20:20)

I don't see a direct dependency on tslib, but something seems to be missing?