sabloger / sitemap-generator Goto Github PK

example:

"example.com/locations?id=xxxx" is encoded, which leads to a 404.

How can we fix it ? @sabloger

hi,

nice package. thank you.
i am looking for a way to receive the sitmap-content. for example to return it with http.ResponseWriter.Write(content)
think it woul be possible if the there would be a method to get the value from Sitemap.content or if Sitemap.content would be available outside by changing it to Sitemap.Content

do you think this is a good idea?

thank you advance.
best florian

In *SitemapIndex.saveSitemaps and *SitemapIndex.PingSearchEngines the WaitGroup.Done may never be called when the go routine returns early in case of error and that would cause WaitGroup.Wait never stop waiting. To fix it moves.wg.Done() to the top of the go routine using defer. defer s.wg.Done()

sabloger/sitemap-generator always trims the trailing slash.

sitemap.Add(&smg.SitemapLoc{
	Loc: "about/",
})

The code above generates

<url>
  <loc>https://example.com/about</loc>
</url>

Which should be https://example.com/about/ instead.

A given result like is making bad Google SEO, because the sitemap is giving URLs that redirecting pages.