s1syphos / kirby-webp Goto Github PK

View Code? Open in Web Editor NEW

31.0 5.0 4.0 4.15 MB

WebP generation for Kirby

License: MIT License

PHP 100.00%

kirby kirby-cms kirby-plugin webp webp-generation webp-generator webp-images images performance speed

kirby-webp's People

Contributors

Stargazers

Watchers

Forkers

daybugging pascalmh kenser rosell-dk

kirby-webp's Issues

Update to kirby version 3

Hey, thanks for your effort in this project, I want to ask if it would be possible to bring this plugin to kirby version 3? It looks like it only supports v2 right now. I would help porting this plugin to v3 if it's accepted from your side. Have a nice day!

Mistake in Nginx Settings

You are saying:

location ~* ^.+\.(jpe?g|png)$ {
    add_header Vary Accept;
    // .. and if so, serving it
    try_files $1$webp_ext $uri =404;
  }

However it must be $webp_suffix because $webp_ext is not set in http as a variable.

But nonetheless I have the problem that my sever doesn't serve the file in webp :(

Do not return anything inside hook

A hook is not expected to return anything. You cannot control the user flow with hooks at this state. They are silently triggered.
https://getkirby.com/docs/developer-guide/advanced/hooks

https://github.com/S1SYPHOS/kirby-webp/blob/master/core/generate_webp.php#L65