rzari / jarling Goto Github PK

StarlingBase.java - transactionDateFormat using minutes instead of month
(yyyy-mm-dd -> YYYY-MM-dd).

PR has been submitted to resolve this.

It appears there is a mismatch between a transaction value and adding money to a savings goal.

When retrieving Transactions, these are retrieved in decimalised pounds (ie 44.32, £44.32).
When calling: /savings-goals/$savingsGoalUid/add-money/$transactionUID, it appears the payload amount is expected in in pence (ie 500, £5).

Simple fix would be to amount = amount.multiply(new BigDecimal(100)) within the addMoneyToSavingsGoal method.

Alternatively a separate AmountInPence could be created to satisfy the requirement.

We've started to use this library to connect to Starling's API and have noticed a warning on Starling's docs saying that "Our V1 APIs have now reached end-of-life and will be retired in Q4 2019. All API connectivity should now use V2."

Do you know of any work so far on this client to support the V2 API? If not, we'd be happy to start making some PRs to add the functionality.

Thanks for all your hard work so far!