Git Product home page Git Product logo

Comments (6)

ryukinix avatar ryukinix commented on June 4, 2024 1

Hmmm... indeed this question is asked always when a series has been finished. I should look into this further and figure out what we can do to create a better UX.

This should change, anyway, at least let the user remains using the old score if it wish.

Thanks for the feedback!

from mal.

evanjs avatar evanjs commented on June 4, 2024 1

Maybe it could still prompt the user but default to the score the user has previously entered.
For example, if I finished Shippūden with a score of 9, the message would be "Please enter a score, or hit enter to leave at 9", etc.

If the user has not yet given the anime a score, it could default to zero, and the message could read "Please enter a score, or hit enter for 0"

from mal.

mparadinha avatar mparadinha commented on June 4, 2024

In case the user had already given a score prior but wanted to leave it with no score after completion, how should we got about that? Maybe we could do like @evanjs proposed and have it so a blank response keeps the current score and a hyphen would make so no score exists.

from mal.

ryukinix avatar ryukinix commented on June 4, 2024

@mparadinha the idea of @evanjs is good. We could do that. But about the hyphen this is not necessary because 0 not means the score 0, because is not possible give 0 on MAL. 0 means "non-scored" which has the functionallity of your suggestion about the hyphen stuff.

We still should ask always for the user about the score because is something I wanted on the first version and I still want. In some way is pretty common to me finish a series and given a score. I'm a linear person, sometimes.

But we should do two things on this thread as we discussed:

  • Change the status messages if the anime is already scored like the @kutsan suggested
  • Empty answer means "keep the old score untouched" (if nothing is scored yet, would remains the same)

This is pretty straightforward to implement. Are you ok with that, @kutsan?

from mal.

ryukinix avatar ryukinix commented on June 4, 2024

@kutsan since we (actually @mparadinha) already implemented this feature on #76, I'm closing this issue.

This feature will be released on MAL v0.4, you can wait until that (I don't know yet when I will release although a due date is scheduled to tomorrow on github milestone).

If you already want get this feature you can easily do that by:

pip install git+https://www.github.com/ryukinix/mal

from mal.

kutsan avatar kutsan commented on June 4, 2024

Thanks @ryukinix and others. I think current choice is okay and I am satisfied.

from mal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.