Comments (5)
Thanks for catch that.
Well... this is indeed not a valid date and need to be to parse correctly here: api.py. There a couple of ways to fix that. As this is about how MAL works, I think we should not close the whole application because of that or give any error about it. Because is not a error of MyAnimeList, is a feature (how the PHP developers say, they say). The design is wrong, but that is other history.
A simple strategy to implement one fix for that is keep the raw date untouched, as 2011-05-00
in your case, if a exception is signalized. Or to avoid try/exception blocks, just split by -
and check if some of the tokens are a 0 filled string.
As you see, methods with decorator @checked_regex
and @checked_connection
on api.py
did handle exceptions very well, but I did not write a special case for date format on _fdate
because I didn't even know that MyAnimeList would be send even MORE TYPES of invalid date here.
Anyway, the MAL API... what are they thinking to put a invalid date to store a information of a PARTIAL-DATE?. :/ well, as the MAL API is so wrong in so many levels, this is not even a surprise...
from mal.
Just one thing, I know are you using the PS prompt of Windows, but Ctrl-C
doesn't send a SIGINT signal and close the application when the application throw a exception? Are you tested that?
I don't have sure if Windows implement the POSIX signals, although Windows is not a POSIX system at all.
from mal.
I implemented a simple fix just for you on date-fix
feature branch.
Please, reinstall your mal application with that command:
pip install git+https://www.github.com/ryukinix/mal.git@date-fix
Give me a feedback if this works for you.
from mal.
Yeah, scratch the interrupt statement. Ctrl+C works fine on Gentoo (4.13.4).
Fix seems to work:
PS C:\Users\evanjs> mal filter 'Naruto.*' --extend
Matched 3 items:
1: Naruto
Completed at 220/220 episodes with score 10
Started: 03-04-2011 Finished: NA
Tags: ナルト
2: Naruto x UT
Completed at 1/1 episodes with score 10
Started: NA Finished: NA
Tags: None
3: Naruto: Shippuuden
Watching at 387/500 episodes with score 9
Started: 2011-05-00 Finished: NA
Tags: ナルト疾
from mal.
Nice to hear about it.
from mal.
Related Issues (20)
- MAL API it's broken: HTTP 404 HOT 29
- Refactor travis in favour of github actions
- Log in loop due to Attribute Error. HOT 2
- User cannot login if password contains unescaped special characters HOT 1
- Add torrent sub-command HOT 21
- Option to disable "back and forth" animation on Windows HOT 8
- Create manpage and distribute with the software HOT 4
- Handle errors better if MyAnimeList API is not accessible HOT 21
- Shouldn't ask for score if score is already given when completing an anime HOT 6
- [solved] Unable to search usernames that start with dash HOT 6
- Store login credentials in encrypted form HOT 15
- [feature request] add 'comments' field to 'edit' function HOT 10
- Document api.py
- [need-update] `anime_regex` is a wrong arg name for search command HOT 3
- [bug] recent change broke search function HOT 5
- Update sphinx docs at /docs before official 0.4.0 release HOT 1
- Abandon appdirs and use ~/.config/mal HOT 10
- [Feature Request] List related anime in extended info HOT 2
- New logo for MAL HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mal.