ryantkerr / ecastingbar-tbc Goto Github PK

World of Warcraft: Classic Addon - a customizable spellcasting bar replacement

Home Page: https://www.curseforge.com/wow/addons/ecastingbarclassic

Lua 53.82% Shell 46.18%

ecastingbar-tbc's Introduction

eCastingBar TBC

The casting bar addon that replaces the default player spellcasting bar with a customizable replacement. This addon has been around since Vanilla WoW, and now it's available for TBC Classic 2.5.1 & Classic WoW 1.13.7.

New Features: Display Latency & Channel Spell Ticks!

About

First of all I'd just like to mention that I am not the original creator of this addon, and for that you can thank Neuro for his old rework, Retloldin for his BFA fork, and all of the past contributors of the project. This wasn't just a simple TOC edit, so if you have any problems feel free to submit any issues.

Installation

Download from Curseforge (updates with Twitch client)

Curseforge Manual Download Install

Unzip and extract eCastingBarClassic-release\eCastingBar into your Addons folder. Putting the eCastingBarClassic-release zip folder into your Addons folder will not work.

Github Release Page Download

Unzip and extract eCastingBarClassic-release\eCastingBar into your Addons folder. Putting the eCastingBarClassic-release zip folder into your Addons folder will not work. Make sure the eCastingBarClassic folder is named eCastingBar in your Addons folder.

Configuration

Type /ecb or /ecastingbar to open the config menu.

ecastingbar-tbc's People

Contributors

Stargazers

Watchers

Forkers

drveoj scottsdevelopment

ecastingbar-tbc's Issues

Target Cast Bar?

I noticed you removed the target cast bar from the options menu. I s there a limitation in Classic or why is that? Would you add it back anytime soon?

Borders can't be hidden

Hi, I can't get rid of the borders, despite I check the "Hide border" box, borders simply stay there.
Is there aby other way to do that?
Thanks.

Cast bar "fill up" not smooth

Hey there, so when you're casting a spell and the bar is "filling up" it seems to do it in chunks, instead of it being smooth and fluid. Is this intended?

Channeling ticks don't clear

After casting Drain Soul the ticks show on other spells.

Spell levels

Please, add spell`s rang into spell name string on casting bar. its important for healers in vanilla

Spell rank not showing

Spell rank doesn't seem to be being displayed anywhere when checking the option to.

1.14 support?

Can we please have an update on if 1.14 will be supported?

Cast Bar Lock??

Test Mode

Doesn't seem to be a way to get rid of test mode? Maybe an unexpected return in the testModeMirror() function & its continuing to show the mirror?

Feature request - Implements YaHT muiltishot and aim shot castbar

YaHT is an addon that adds a castbar to aimed shot and multishot hunters spells.
eCastingBar cast isn't catching up those casts from default UI

Here is a link to the thread on YaHT repository, including a link that may help.
Aviana/YaHT#35 (comment)

Cast bar interrupts itself when trying to cast another spell (but spell continues to cast) - With fix

When casting a spell and trying to cast another, it sends a "UNIT_SPELLCAST_FAILED" which stops the cast bar. It's not the current spell that failed to cast but the other spell, so it shouldn't stop the cast bar.

I hotfixed this by changing line 234 to :
elseif(newevent == "UNIT_SPELLCAST_INTERRUPTED" or (newevent == "UNIT_SPELLCAST_FAILED" and spellname ~= barText.spellname) ) then

I don't know if it's enough to cover all cases but it works fine as far as I tested.

Spell text (long name) overlaps with cast time

Dragonflight Beta / 10.0 PTR support please!

ECB looks completely broken even the slash command doesn't work in the beta. I know this repo is for Classic but would you be kind enough to check this masterpiece if there's a way to fix it for Dragonflight Beta / 10.0 PTR please?

Some LUA bugs I caught so far:

1x Interface/AddOns/eCastingBar/eOptions.lua:3: CreateFrame(): Couldn't find inherited node "TabButtonTemplate"
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/eCastingBar/eOptions.lua"]:3: in main chunk

Locals:
(*temporary) = "Button"
(*temporary) = "eCBTestButton"
(*temporary) = UIParent {
0 = <userdata>
ContainerFrames = <table> {
}
firstTimeLoaded = 1
Tabs = <table> {
}
}
(*temporary) = "TabButtonTemplate"

5x Interface/SharedXML/SharedUIPanelTemplates.lua:503: attempt to index field 'Text' (a nil value)
[string "@Interface/SharedXML/SharedUIPanelTemplates.lua"]:503: in function `PanelTemplates_TabResize'
[string "*UnknownFile:199_OnLoad"]:1: in function <[string "*UnknownFile:199_OnLoad"]:1>

Locals:
tab = eCB_OptionFrameCastingTab {
0 = <userdata>
}
padding = nil
absoluteSize = nil
minWidth = nil
maxWidth = nil
absoluteTextSize = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'Text' (a nil value)"
TAB_SIDES_PADDING = 20

1x [string "*UnknownFile:103_OnLoad"]:2: attempt to call global 'eCastingBarOptions_OnLoad' (a nil value)
[string "*UnknownFile:103_OnLoad"]:2: in function <[string "*UnknownFile:103_OnLoad"]:1>
[string "=[C]"]: ?

Locals:
self = eCB_OptionFrame {
 0 = <userdata>
 Center = Texture {
 }
 OnBackdropLoaded = <function> defined @Interface/SharedXML/Backdrop.lua:152
 backdropInfo = <table> {
 }
 backdropBorderColor = <table> {
 }
 GetBackdropColor = <function> defined @Interface/SharedXML/Backdrop.lua:390
 SetupTextureCoordinates = <function> defined @Interface/SharedXML/Backdrop.lua:214
 OnBackdropSizeChanged = <function> defined @Interface/SharedXML/Backdrop.lua:182
 HasBackdropInfo = <function> defined @Interface/SharedXML/Backdrop.lua:278
 SetBackdropBorderColor = <function> defined @Interface/SharedXML/Backdrop.lua:422
 RightEdge = Texture {
 }
 BottomEdge = Texture {
 }
 TopRightCorner = Texture {
 }
 GetEdgeSize = <function> defined @Interface/SharedXML/Backdrop.lua:188
 BottomRightCorner = Texture {
 }
 BottomLeftCorner = Texture {
 }
 TopEdge = Texture {
 }
 ApplyBackdrop = <function> defined @Interface/SharedXML/Backdrop.lua:294
 SetBackdrop = <function> defined @Interface/SharedXML/Backdrop.lua:329
 ClearBackdrop = <function> defined @Interface/SharedXML/Backdrop.lua:282
 TopLeftCorner = Texture {
 }
 GetBackdropBorderColor = <function> defined @Interface/SharedXML/Backdrop.lua:409
 GetBackdrop = <function> defined @Interface/SharedXML/Backdrop.lua:347
 backdropBorderColorAlpha = 0.250000
 SetupPieceVisuals = <function> defined @Interface/SharedXML/Backdrop.lua:246
 SetBackdropColor = <function> defined @Interface/SharedXML/Backdrop.lua:399
 LeftEdge = Texture {
 }
 SetBorderBlendMode = <function> defined @Interface/SharedXML/Backdrop.lua:266
}
(*temporary) = nil
(*temporary) = "attempt to call global 'eCastingBarOptions_OnLoad' (a nil value)"

"Hide Outline" checkbox in settings doesn't correctly load saved value

"Hide Outline" button in both Casting Bar and Mirror Bar always loads itself to unchecked (you have to check in then uncheck it for the Outline to show if you had it saved to be hidden before reload).

Feature Req: Change border type & Color - Don't show latency text

Title pretty much says it. I really don't like that fat white border, and the latency text is hidden behind the cast time text when using small height.