ryancramerdesign / inputfieldckeditor Goto Github PK

I have a strange issue on my xampp localhost environment. I have setup inline editing mode and I can able to use toolbar when I am editing contents and able save contents successfully. After doing quite of bit of time editing and saving, my toolbar gets disabled and I cannot able to use it to style on contents in the field but the another field with inline editing mode on the same page shows toolbar fine. I logged out out, closed browser and went back to same field and I still have same issue. Even I changed field setting to regular mode and I got no contents and disabled toolbar. I switched back to TiinyMCE and it works fine.

Hi Ryan,

sorry to bother you again, but when using the current version of the module in inline mode, I get a lot of strange JS errors like Cannot read property 'br' of undefined or Cannot read property 'undefined' of undefined.

There are no problems like this in my commit from PR #6, so the must somehow stem from the other changes you made in ed5b31e.

I'm going to look further into this in the next days.

Say you type in www.example.com inside the Link to URL field, this will be treated like a relative link (e.g. http://www.mysite.com/blog/hello-world/www.example.com). Is this by choice?

I try to use CKEditor and JqueryCore modules at the frontend and it conflicts.

Reproduce:
Generate a form with a ckeditor inline field via form api and also load JqueryCore module.

Uncaught TypeError: undefined is not a functionInputfieldCKEditor.js?v=128:90 (anonymous 
function)JqueryCore.js?v=183:2 v.event.dispatchJqueryCore.js?v=183:2 o.handle.u

Without JqueryCore module loaded all works fine.

http://processwire.com/talk/topic/4821-insert-link-module-tinymce-with-link-to-page-language-support/

I know this is pedantic, but:

This is more faster and more efficient

When pressing the anchor button it triggers a transparent layer but further nothing happens. No javascript errors what so ever. A page reload is needed to be able to continue.

If I add a custom styles.js and point to it from my field's settings, the styles dropdown gets greyed out. Pretty sure I've got everything set up correctly with path to the file and the name in the settings matching the name in the file itself.

So I thought I'd try editing CKEditor's own styles.js but when I do, nothing changes in the CP.

This is with the latest versions of the module and Processwire.

The CKeditor throws an error, unfortunatly, and does not show on the PW edit pages here. (seen in SAFARI Mac and Firefox):

Error] TypeError: 'undefined' is not an object (evaluating 'a.attributes')
style (ckeditor.js, line 423)
init (ckeditor.js, line 753)
(anonyme Funktion) (ckeditor.js, line 235)
n (ckeditor.js, line 215)
load (ckeditor.js, line 215)
(anonyme Funktion) (ckeditor.js, line 234)
(anonyme Funktion) (ckeditor.js, line 222)
(anonyme Funktion) (ckeditor.js, line 220)
n (ckeditor.js, line 215)
r (ckeditor.js, line 215)
o (ckeditor.js, line 215)
(anonyme Funktion) (ckeditor.js, line 216)

Note: The fields in question are converted, not new. Maybe that is important:
The field had been TinyMCE fields before, which worked. Today I switched to CKE (latest module, latest purifier module, latest PW dev).

Am I the only one with this?

The configuration of the enterMode has a flaw that causes some bugs like preventing someone from pasting particular formatted MS Word text.

The enterMode is set in PHP as follows:

        $config = array(
            ...
            'enterMode' => 'CKEDITOR.ENTER_P',
            ...
            );

The problem there is that json_encode puts that value in quotes:

"enterMode":"CKEDITOR.ENTER_P"

But it's really a constant and not a string. That leads to some rare errors.
You can't change that behaviour of json_encode, so I see two options at the moment:

• Change 'CKEDITOR.ENTER_P' to 1 (as this is the value of that constant, but this wouldn't be future proof in my eyes)
• Move that enterMode config somewhere else to prevent it from being processed by json_encode

Hello Ryan,

thanks for this great module in the first place. I just recognized one slight issue that occurs to me, when I use the Inputfield in inline mode:

If i set an anchor to be opened in a new window/tab, this is not persisted to the database. The HTML is correct right after editing (checking with the CKEditor HTML view), but after saving the page this is lost again.

I'm pretty sure, that this is caused by a too strict configuration of the HTMLPurifier module, but didn't have enough time to look further into it until now.

With kind regards,
Marc

Edit: I think this can be fixed by setting Attr.AllowedFrameTarget to array('_target') before purifying, can't test it at the moment, though,

At the moment it seems that CKEditor is automatically adding inline tools for all textarea instances with contenteditable attribute set to true. Please correct me if I'm wrong, but this doesn't seem like correct behaviour?

I stumbled into this while working on proof-of-concept Trumbowyg inputfield, which also uses contenteditable. The problem is that unless I add "CKEDITOR.disableAutoInline = true;" into it's JS file, CKEditor keeps adding it's own toolbar on top of Trumbowygs.. :)

If one tries to add a link or image while editing a text in Maximize view, the corresponding overlays are covered behind the Maximize overlay itself.