Sound is quite complicated, a fully-featured sound system should expose mechanisms for multiple audio streams: UI, Dialogue, and game-play.

Might it get away with having a simple API like Play Sound ( Stream, Sound File )

To increase the utility of the script debugger, it would be nice if we could display a simple disassembly of the game script surrounding the program counter. This is easy enough in the forward direction, since the instruction size is known, but is difficult to reliably reverse.

To make it possible to show instructions behind the program counter as well as ahead, parsing of the instructions could be done with a Disassembler that accepts the known VM opcode definitions and hard-coded funky business the SCM does, producing an in-order list of all the instruction addresses within the SCM file.

Clean up GameWorld to be more a container for temporary runtime object state. Make sure the classes are in sensible locations too.

• Move GameObject into rwengine/objects

The player doesn't respawn when he dies, and this causes funny effects.

I killed myself with a rocket launcher, and it caused me to die and fall down to the ground. Although I couldn't move anymore, I was still able to jump and shoot guns.

Using the NVIDIA proprietary drivers 364.19 on Arch Linux causes the minimap to go out of it's window. This is not reproducable on Mesa.

At this moment you have to export the OPENRW_GAME_PATH variable to get your game to run. It would be preferable to have a config file (say ~/.config/openrw/config) to specify the location of the game. This would allow .desktop files to run the game, as you don't have to export the variable every time anymore.

As title says, maybe we can get a localized game?

Thing

More Thing

Thingy

• foo
• bar
• baz
• foo
• bar
• baz
• foo
• bar
• baz
• foo
• bar
• baz
• foo
• bar
• baz
• foo
• bar
• baz

You can trigger an assertion fail if you start the game and press enter during the cutscene. I got this backtrace:

Starting program: /home/g/Games/openrw/rwgame/rwgame 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff094a700 (LWP 6711)]
I [Game] Game directory: /home/g/Games/GTA3
Max UBO Size: 16384
UBO Alignment: 16
Max batch size: 128
I [Renderer] OpenGL Renderer Version: 3.0 Mesa 10.1.3 (GLSL 1.30) Vendor: Intel Open Source     Technology Center
[New Thread 0x7fffe8dc2700 (LWP 6714)]
[Thread 0x7fffe8dc2700 (LWP 6714) exited]
[New Thread 0x7fffe8dc2700 (LWP 6715)]
[New Thread 0x7fffdffff700 (LWP 6716)]
I [Data] Loaded 42 zones from /home/g/Games/GTA3/data/gta3.zon
I [Game] Started
Failed to open sound file "/home/g/Games/GTA3/audio/City.wav" (System error : No such file or directory.)
I [World] Loaded cutscene: BET
[New Thread 0x7fffd742d700 (LWP 6744)]
[Thread 0x7fffd742d700 (LWP 6744) exited]
libmad error: lost synchronizationlibmad error: lost synchronizaI [World] Loaded cutscene: JB
[New Thread 0x7fffd742d700 (LWP 6748)]
I [World] Creating Vehicle ID 116 (POLICAR)
I [World] Creating Vehicle ID 117 (ENFORCR)
I [World] Creating Vehicle ID 130 (RUMPO)
I [World] Creating Vehicle ID 96 (PATRIOT)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
rwgame: /usr/include/glm/detail/func_exponential.inl:149: genType glm::sqrt(const genType&)     [with genType = float]: Assertion `x >= genType(0)' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff59a7cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56  ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  0x00007ffff59a7cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007ffff59ab0d8 in __GI_abort () at abort.c:89
#2  0x00007ffff59a0b86 in __assert_fail_base (fmt=0x7ffff5af1830 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x69cb75 "x >= genType(0)", file=file@entry=0x69cb48 "/usr/include/glm/detail/func_exponential.inl", 
    line=line@entry=149, 
    function=function@entry=0x69cec0 <float glm::sqrt<float>(float const&)::__PRETTY_FUNCTION__> "genType glm::sqrt(const genType&) [with genType = float]") at assert.c:92
#3  0x00007ffff59a0c32 in __GI___assert_fail (assertion=0x69cb75 "x >= genType(0)", file=0x69cb48 "/usr/include/glm/detail/func_exponential.inl", 
    line=149, 
    function=0x69cec0 <float glm::sqrt<float>(float const&)::__PRETTY_FUNCTION__> "genType glm::sqrt(const genType&) [with genType = float]")
    at assert.c:101
#4  0x0000000000581bfa in float glm::sqrt<float>(float const&) ()
#5  0x000000000058fbb2 in float glm::length<float, (glm::precision)0>(glm::detail::tvec3<float,    (glm::precision)0> const&) ()
#6  0x00000000005e06e5 in renderGeometry(GameWorld*, Model*, unsigned long, glm::detail::tmat4x4<float, (glm::precision)0> const&, float, GameObject*, ViewCamera const&, std::vector<Renderer::RenderInstruction, std::allocator<Renderer::RenderInstruction> >&) ()
#7  0x00000000005e1b3c in renderWheel(GameWorld*, VehicleObject*, Model*, glm::detail::tmat4x4<float, (glm::precision)0> const&, std::string const&, ViewCamera const&, std::vector<Renderer::RenderInstruction, std::allocator<Renderer::RenderInstruction> >&) ()
#8  0x00000000005e22cb in renderVehicle(GameWorld*, VehicleObject*, ViewCamera const&, float, std::vector<Renderer::RenderInstruction, std::allocator<Renderer::RenderInstruction> >&) ()
#9  0x00000000005e30bd in ObjectRenderer::buildRenderList(GameWorld*, GameObject*, ViewCamera const&, float, std::vector<Renderer::RenderInstruction, std::allocator<Renderer::RenderInstruction> >&) ()
#10 0x00000000005cc843 in GameRenderer::renderWorld(GameWorld*, ViewCamera const&, float) ()
#11 0x000000000057d3e2 in RWGame::render(float, float) ()
#12 0x000000000057c380 in RWGame::run() ()
#13 0x00000000005779e2 in main ()

A header

Another header

Yet another header

• a checkbox
• another checkbox
• more checkboxes
• more checkboxes
• foo
• bar

The game is not rendering at "normal" speed despite it is using all the processors. Maybe my netbook is too slow to play it (it has two Intel Celeron @ 1.46GHz)?

After causing a self-driving car as explained in issue #31 ,pressing the enter vehicle button results in the player following the car regardless of distance or any movement keys pressed.

Hi

Can I run this game on Mac?

This is a tracking issue for the main game story.

Tests are currently split between the tests directory, and rwengine/tests.

Tests should be organised into folder of the component they are for:

• rwgame/tests
• rwcore/tests
• rwengine/tests

etc.

The game behaves in a really non-useful way when focus is lost

• The mouse is still warped to the centre of the window
• Stop pausing on focus lost

The following things could be moved from rwengine:

• Everything in rwengine/{src,include}/core

The renderer is very primitive at the moment. Some notes:

• There's a lot of logic in GameRenderer.cpp, I think for the most part this could be moved elsewhere, leaving just low level culling and rendering command / scene stuff in GameRenderer.
• Visible objects should be converted to drawing commands that are sortable by texture, transparency, geometry etc so that GameRenderer doesn't need to know anything about GameObjects

Will require parsing the chase.dat files
http://www.gtamodding.com/index.php?title=Chase.dat

The camera should be modelled as a floating mass that gets pulled toward a fixed radius around the target object. This would fix all of the current issues with the in game camera behaviour and would simply enable support for smoothly moving the camera to the player.

Panning left and right could easily be achieved by pushing the camera to the right or left as determined by the cross product of the camera -> target vector and the up vector.

Story Missions

Portland

8-Ball

• Give Me Liberty

Luigi

• Luigi's Girls
  • Cutscene camera is wrong in one scene
• Don't Spank Ma Bitch Up
• Drive Misty For Me
• Pump-Action Pimp (optional)
• The Fuzz Ball (optional)
  • Broken world (Culling bad?)
  • Thinks the car is full (Opcodes 01EA and 01E9)
  • Missing timer

Joey

• Mike Lips Last Lunch
  • Bombshop doesn't work
• Farewell 'Chunky' Lee Chong
  • Missing fight AI
• Van Heist
  • Camera in cutscene broken
  • Missing vehicle AI
  • Even if van is stolen no instructions are given
  • Van almost undrivable due to physics
• Cipriani's Chauffeur
  • Crashes before cutscene because vehicle in opcode_01f4 is nullptr (why?)
• Dead Skunk in the Trunk (optional)
  • Missing vehicle AI (Forelli Brothers don't work)
  • Crusher doesn't work
• The Getaway (optional)
  • Nothing happens at pickup location

Toni

• Taking Out The Laundry
  • Vans can not be destroyed
• The Pick-Up
  • Can't pickup the briefcase
• Salvatore's Called A Meeting
  • Cutscene / entering the limo at Joes does never ends

Salvatore

• Chaperone
  • Camera in cutscene is bad
  • Cutscene never ends

Toni

• Triads and Tribulations
  • Crash in opcode_00a1 after cutscene (character is nullptr maybe?)
• Blow Fish

Salvatore

• Cutting The Grass
• Bomb Da Base: Act I

8-Ball

• Bomb Da Base: Act II

Salvatore

• Last Requests

Staunton Island

Asuka

• Sayonara Salvatore
• Under Surveillance
• Paparazzi Purge
• Payday For Ray
• Two-Faced Tanner

Kenji

• Kanbu Bust-out
• Grand Theft Auto
• Deal Steal
• Shima
• Smack Down

Ray

• Silence The Sneak
• Arms Shortage
• Evidence Dash
• Gone Fishing
• Plaster Blaster

Donald

• Liberator
• Waka-Gashira Wipeout
• A Drop In The Ocean
• Grand Theft Aero
• Escort Service
• Decoy
• Love's Disappearance

Ray

• Marked Man

Asuka

• Bait
• Espresso-2-Go!
• S.A.M.

Catalina

• Ransom

Shoreside Vale

Catalina

• The Exchange

Arch Linux, all dependencies installed (I can't find "Boost Test", but I have boost installed).

Compiling fails at 71% (main.cpp):

/home/username/Git/openrw/tests/test_globals.hpp:17:8: error: ‘print_log_value’ is not a class template
 struct print_log_value<glm::vec3> {
        ^~~~~~~~~~~~~~~
/home/username/Git/openrw/tests/test_globals.hpp:17:35: error: explicit specialization of non-template ‘boost::test_tools::print_log_value’
 struct print_log_value<glm::vec3> {
                                   ^
/home/username/Git/openrw/tests/test_globals.hpp:27:8: error: ‘print_log_value’ is not a class template
 struct print_log_value<std::nullptr_t> {
        ^~~~~~~~~~~~~~~
/home/username/Git/openrw/tests/test_globals.hpp:27:38: error: ‘boost::test_tools::print_log_value’ is not a template
 struct print_log_value<std::nullptr_t> {
                                      ^
/home/username/Git/openrw/tests/test_globals.hpp:17:8: note: previous declaration here
 struct print_log_value<glm::vec3> {
        ^~~~~~~~~~~~~~~
tests/CMakeFiles/run_tests.dir/build.make:62: recipe for target 'tests/CMakeFiles/run_tests.dir/main.cpp.o' failed
make[2]: *** [tests/CMakeFiles/run_tests.dir/main.cpp.o] Error 1
CMakeFiles/Makefile2:308: recipe for target 'tests/CMakeFiles/run_tests.dir/all' failed
make[1]: *** [tests/CMakeFiles/run_tests.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

Game crashes with a segfault when entering the first Safehouse. (Only tested after beginning the first mission)
Hardware is an AMD A8-7410 APU with fglrx 15.3

Terminal output follows.

I [Data] Loaded 42 zones from /opt/games/Grand Theft Auto 3//data/gta3.zon
I [Game] Started
I [World] Loaded cutscene: BET
libmad error: lost synchronizationlibmad error: lost synchronizaI [World] Loaded cutscene: JB
I [World] Creating Vehicle ID 116 (POLICAR)
I [World] Creating Vehicle ID 117 (ENFORCR)
I [World] Creating Vehicle ID 130 (RUMPO)
I [World] Creating Vehicle ID 96 (PATRIOT)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 111 (KURUMA)
I [SCM] Restarting Critical Mission
Segmentation fault

Currently, WINE must be used to run the original PC version of GTA 3 on Linux. By writing OpenRW, it should become possible to play the game with a native binary with better support for modern hardware.

Before much more work can be done on the script VM, we need the functionality to store and retrieve the game state.

The VM state is dependant on a few other bits of information, so the following is roughly what needs to be saved to allow restoration of the state:

• Almost everything within GameState needs to be saved.
• Certain objects need to be saved (InstanceObjects can probably be ignored, with a few exceptions), almost everything found in .IPL files doesn't need to be restored.

Once this information is stored, the state of threads and the VM memory can be trivially restored.

All input is currently hard coded. We should allow input to be re-mapped and display the correct key or button in the displayed help messages.

The script VM currently stores a pointer to game objects, this is totally unsafe as script variables rely on type erasure. scripts can pass in arbitrary data to functions which is not wanted behaviour.

GameObjects should be allocated an immutable ID that is stored in place of a pointer to the object. The script arguement construction can the look up the object and verify its existence and type.

The deferred rendering pipeline isn't merged with the main development branch yet

I think adding some screenshots in the README can show the current progress to potential alpha-tester.

Arch Linux, proprietary NVIDIA drivers 364.19.
The game is red, and the sky is sort of green/blueish.
After a while of running around the graphics start glitching around and colliding with each other.

(ignore the minimap out of it's window, that is reported at #25 already)

Camera up/down is inverted as of 39c639f commit revamping the behavior of the camera.
Please, please provide a switcher as soon as is convenient.

It would be really nice to play GTA III in the browser!
Planning it from the start might be easier than doing it later.

Interactive web-based script debugging utility

As of this hour, compilation now fails on my Linux system, something relating to GLM. libglm-dev is installed, but make results in

-- Found SFML 2.1.0 in /usr/include
-- Found MAD in /usr/include
CMake Error at CMakeLists.txt:61 (find_package):
By not providing "FindGLM.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "GLM", but
CMake did not find one.

Could not find a package configuration file provided by "GLM" with any of
the following names:

GLMConfig.cmake
glm-config.cmake

Add the installation prefix of "GLM" to CMAKE_PREFIX_PATH or set "GLM_DIR"
to a directory containing one of the above files. If "GLM" provides a
separate development package or SDK, be sure it has been installed.

-- Configuring incomplete, errors occurred!
See also "/home/taco/stuff/openrw-git/openrw/build/CMakeFiles/CMakeOutput.log".
make: *** [cmake_check_build_system] Error 1

A header

Another header

Yet another header

• a checkbox
• another checkbox
• more checkboxes
• more checkboxes
• foo
• bar

Using enter key, i can't enter cars. Nothing happens. I also noticed that i can walk though cars, but i'm not sure this is related.

Currently you're able to shoot your guns (and throw grenades) even though you have no ammo.

When leaving a vehicle while holding a movement key, the vehicle will continue to move in the pressed direction after the player has left.

GLM is installed but cmake ../ -DCMAKE_BUILD_TYPE=Release fails with the following:

-- Found SFML 2.3.2 in /usr/include
-- Found MAD in /usr/include
CMake Error at /usr/lib/cmake/glm/glmConfig.cmake:10 (message):
File or directory //include referenced by variable GLM_INCLUDE_DIRS does
not exist !
Call Stack (most recent call first):
/usr/lib/cmake/glm/glmConfig.cmake:16 (set_and_check)
CMakeLists.txt:61 (find_package)

-- Configuring incomplete, errors occurred!
#43 seems to have caused this issue.

The bottom of the main bridge (between the start island and the "main land") is black (untextured).

Currently not used in a sensible way, leaking memory.

Subtitles are stacked on top of each other and go away only when scene changes.

Suggestions for code style

• Use google-ish convention for include guards: LIBRARY_FILE_HPP
• document method behaviour if non-trivial
• Adhere to the style of the containing file
• Adopt a sensible variable naming convention:
  • Member Variable identification?
  • avoid single-letter variables outside counters

Progress

• Add GPL notice to header files
• Change existing header guards

Thoughts, @tsjost ?

Trying to feed in a save game from the original game results in the player vanishing - the original game gives different objects a different name space, but OpenRW does not, resulting in the game deleting the player thinking it's a pickup.

Individual object name-spaces:

• Players
• Pedestrians
• Vehicles
• "Objects"
• Pickups

This shouldn't be very difficult, but will requiring changing the code in a lot of places.

Story Missions

Portland

8-Ball

• Give Me Liberty

Luigi

• Luigi's Girls
• Don't Spank Ma Bitch Up
• Drive Misty For Me
• Pump-Action Pimp
• The Fuzz Ball

Joey

• Mike Lips Last Lunch
• Farewell 'Chunky' Lee Chong
• Van Heist
• Cipriani's Chauffeur
• Dead Skunk in the Trunk
• The Getaway

Toni

• Taking Out The Laundry
• The Pick-Up
• Salvatore's Called A Meeting

Salvatore

• Chaperone

Toni

• Triads and Tribulations
• Blow Fish

Salvatore

• Cutting The Grass
• Bomb Da Base

8-Ball

• Bomb Da Base

Salvatore

• Last Requests

Staunton Island

Asuka

• Sayonara Salvatore
• Under Surveillance
• Paparazzi Purge
• Payday For Ray
• Two-Faced Tanner

Kenji

• Kanbu Bust-out
• Grand Theft Auto
• Deal Steal
• Shima
• Smack Down

Ray

• Silence The Sneak
• Arms Shortage
• Evidence Dash
• Gone Fishing
• Plaster Blaster

Donald

• Liberator
• Waka-Gashira Wipeout
• A Drop In The Ocean
• Grand Theft Aero
• Escort Service
• Decoy
• Love's Disappearance

Ray

• Marked Man

Asuka

• Bait
• Espresso-2-Go!
• S.A.M.

Catalina

• Ransom

Shoreside Vale

Catalina

• The Exchange

Hi

After building and installing the game, running results in:

Warning: The created OpenGL context does not fully meet the settings that were requested
Requested: version = 1.1 ; depth bits = 32 ; stencil bits = 0 ; AA level = 0 ; core = false ; debug = false
Created: version = 4.5 ; depth bits = 24 ; stencil bits = 0 ; AA level = 0 ; core = false ; debug = false
I [Game] Game directory: /tank/storage/GTA3/
Max UBO Size: 65536
UBO Alignment: 256
Max batch size: 512
I [Renderer] OpenGL Renderer Version: 4.5.0 NVIDIA 352.63 (GLSL 4.50 NVIDIA) Vendor: NVIDIA Corporation
I [Data] Loaded 42 zones from /tank/storage/GTA3//data/gta3.zon
I [Game] Started
[1]    11543 segmentation fault (core dumped)  rwgame

When focus to the game window is lost, the camera will stop following moving vehicles.

I'm scene where Luigi gives you Luigis girls mission characters clip through the door when they come to talk with you.

Failed to open WAV sound file (invalid or unsupported file)
E [Data] Error loading audio clip /home/aukondk/Games/steamcmd_linux/gta3/audio//lib_a1.wav
E [Data] MP3 Audio unsupported outside cutscenes
E [SCM] Failed to load audio: lib_a1

I checked the WAV file and it plays fine in Audacity and is named correctly (all lower case).

When your mouse cursor is inside the game window, it dissapears. It would be much easier to select menu options (both main menu and when pressing "escape" in-game) when there is a mouse cursor. The native system cursor will do I guess.