rvprasad / dyco4j Goto Github PK

• methodNameRegex to method-name-regex
• traceArrayAccess to trace-array-access
• traceFieldAccess to trace-field-access
• traceMethodArgs to trace-method-arguments
• traceMethodReturnValue to trace-method-return-value

When writing classes using a ClassWriter created with COMPUTE_FRAMES options (required for internals instrumentation), ASM looks for classes/interfaces inherited by instrumented classes. For this search to succeed, all classes required by instrumented classes should be available on the classpath of the instrumenter.

When the instrumentation injects an outermost exception handler in X(X s), the handler covers the super call. Since this variable is uninitialized before the super call and then initialized after the super call, there is a conflict in the frames that reach the handler; specifically, they differ in terms of flags (refer to section 4.10 of the Java Virtual Machine Specification, Java 8 Edition).

Here's an example to repro the issue. Compile it and run class X.

public class X extends Y {
    public X(X s) {
        super(new Y("as"));
    }

    public static void main(String[] s) { }
}

class Y {
    Y(Object o) {}
}

This applies to both entry.CLI and internals.CLI.

Look at AbstractCLITest.groovy/LOGGING_LIBRARY field. It would be best if the library info could be passed into the tests from Gradle.

• internals
• entry

• Describe how to generate logs for open source project.

Due to the bug 8172282 in JDK 8u112, the commit 45cef8e to fix issue #35 splits the outermost exception handler to not cover the call to the super class method. Once the JDK bug is fixed, address this issue by following the instructions for FIXME-1 in InitTracingMethodVisitor.java and make sure all tests pass; specifically, the ones in instrumentation:dyco4j/instrumentation/internals/CLIInitializerInstrumentationTest.groovy.

https://docs.gradle.org/current/userguide/partr3_multi_project_builds.html

Make sure invokedynamic invocations are also captured.

Currently, logs of two different call sites (for the same invoked method) in a method cannot be differentiated. So, associate a call site id to differentiate logs from different call sites in a method.

• Rewrite implementation in Kotlin
• Rewrite tests in Kotlin using Kotest

Instead of logging "tid,1,entry,m1", log "tid,entry,m1".

LoggerInitializer.initialize does not check if an instance of logger has been created. So, new logger in place of the current logger are created as each class is loaded.

Make sure externally dependencies is appropriately documented.