rustwasm / binary-install Goto Github PK

Related issue of rustwasm/wasm-pack#1347 .

Would love

• cargo publish permissions
• repo permissions

ofc open for discussion and buy-in from rustwasm folks and @ashleygwilliams

cc @drager

🐛 Bug description

From my understanding here are the steps that download does:

1. defines a destination (return if already exists)
2. download and extract in a temporary directory
3. rename the temporary directory to the final destionation

Now imagine a concurrent install is running, if after the step 1. another installation succedeed the rename (step 3.) will fail (however, only under Linux because of different syscalls).

🤔 Expected Behavior

Work

👟 Steps to reproduce

Use download with the same package concurrently (in multiple cargo test for example).

🌍 Your environment

Include the relevant details of your environment.
binary-install version: master
rustc version: 1.36.0-nightly
OS: Linux

The current release has been "alpha" for quite a while - I'm not quite sure what has to happen to stabilize, but I'm very happy to help!

Hi, now that #21 has been merged, would it be possible to get a new release published on crates.io? This is needed for wasm-pack to be able to use the new version, in rustwasm/wasm-pack#1188.

Corporate proxies love to kill tls connections with breaking handshakes etc etc. In this case -k option curl helps a lot. For example, cargo has similar option "check-revoke".
Is it possible to provide such option so it will invoke curl with -k option?
I personally struggling with it when using wasm-pack.

failure is dead, long live anyhow.

This will make moving some dependents of this crate from failure to anyhow easier as well.

💡 Feature description

Hi folks! Thank you for all the hard work on Rust's wasm tooling.

I'm looking to download the Tailwind CSS CLI, and those binaries aren't compressed. Currently binary-install panics if you try to download a non-compressed URL.

Is this a feature y'all would be interested in including? If so, I'm happy to think through the API design.

💡 Feature description

ureq is a rust-only library and doesn't require libssl-dev, openssl etc. in ci environments

https://rustsec.org/advisories/RUSTSEC-2020-0053

Crate:         dirs
Version:       1.0.5
Warning:       unmaintained
Title:         dirs is unmaintained, use dirs-next instead
Date:          2020-10-16
ID:            RUSTSEC-2020-0053
URL:           https://rustsec.org/advisories/RUSTSEC-2020-0053
Dependency tree:
dirs 1.0.5
└── binary-install 0.0.2

dirs is unmaintained, dirs-next should be used instead.

I would be willing to implement this and submit a PR if it would be accepted.

🐛 Bug description

This bug happened in

Error Access is denied. (os error 5) occurs when call fs::rename.

I have tested that fs::rename can be renamed correctly in my program, but there are permissions problems in binary-install.
I just learned rust and don’t know how to solve this bug.

🤔 Expected Behavior

Rename successfully.

👟 Steps to reproduce

cloudflare/wrangler-legacy#1504 (comment)

🌍 Your environment

OS: Windows 10 v2004
binary-install version: 0.0.3-alpha.1
rustc version: rustc 1.46.0 (04488afe3 2020-08-24)

🐛 Bug description

The zip crate hasn't been updated in almost a year, and has a number of bugs that can cause panics when trying to process an invalid zip file. It should be replaced with zip_next, a fork I actively maintain.