Git Product home page Git Product logo

Comments (7)

djc avatar djc commented on May 28, 2024

Are you setting an actual DNS server name separately? Because rustls doesn't currently support IP addresses in certificates it won't otherwise be able to establish a session anyway.

from hyper-rustls.

digitwolf avatar digitwolf commented on May 28, 2024

I am not using a DNS, but I am using custom certs and all custom rustls cert verifiers. I have checked locally and this works.

from hyper-rustls.

digitwolf avatar digitwolf commented on May 28, 2024

This is the only change (in external codebase) that is needed to make requests to IP with rustls work #182

from hyper-rustls.

BiagioFesta avatar BiagioFesta commented on May 28, 2024

Because rustls doesn't currently support IP addresses in certificates

Shouldn't rustls/rustls#1032 mitigate this?

I see this current main branch depends on rustls 0.20.1 (so probably that PR is not in the code)

With that patch on rustls and a custom cert verifiers (thus, dangerous config), it should be feasible if I am not wrong.

from hyper-rustls.

digitwolf avatar digitwolf commented on May 28, 2024

Hi BiagioFesta!
I tried your idea locally. I've upgraded hyper-rustls dependency of rustls to 0.20.7 however on it's own that does not address it.
I think that the main issue still exists - square brackets are not accounted for in rustls.
But I do like the idea of upgrading the dependency. I'll update the PR to include the version bump.

from hyper-rustls.

digitwolf avatar digitwolf commented on May 28, 2024

Guys, thank you for pulling in the PR.
Does anyone have an idea when I can expect it to be released?

I have to make a call today to decide if I am pulling in this fix from crates.io or if I need to embed a copy of hyper-rustls in my software release.

from hyper-rustls.

djc avatar djc commented on May 28, 2024

I've submitted #183.

from hyper-rustls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.