Prepare v0.25 release, update to Rustls v0.22 about hyper-rustls HOT 5 CLOSED

Looks complete to me!

from hyper-rustls.

I find "The Acceptor module" confusing, since that doesn't look like a module name?

Good catch, that should be acceptor not Acceptor. Fixed.

And you didn't link the PR here and I'm too lazy to dig up the PR right now.

That one is #219 The PRs will be linked from the GitHub generated changelog for the final release notes so I didn't source them for the proposed text.

Also "accessors fns" I would probably write as "accessor functions" or "accessor methods" maybe.

I split this out into a line about the acceptor module being public, and a separate line about TlsStream getting the new accesor methods.

Maybe the rustls dependency update should move to the top of the list?

Done.

Thanks for the review 👍

from hyper-rustls.

@djc @ctz Would you folks mind +1ing the proposed changelog in comments here? There wasn't a code change to merit a pull request but it makes the "approval" of this proposed release a little awkward :-)

from hyper-rustls.

• The Acceptor module is now public and has io and connection accessors fns for getting a reference to the underlying I/O stream and rustls::ServerConnection.

I find "The Acceptor module" confusing, since that doesn't look like a module name? And you didn't link the PR here and I'm too lazy to dig up the PR right now. Also "accessors fns" I would probably write as "accessor functions" or "accessor methods" maybe. Maybe the rustls dependency update should move to the top of the list?

👍 modulo these nits.

from hyper-rustls.

• Pushed a v0.25.0 tag
• Published hyper-rustls v0.25.0 at registry crates-io
• Created a 0.25.0 GitHub release

from hyper-rustls.