Doctest doesn't print valid assert file line and column location link about rust HOT 10 OPEN

This seems low priority. I value this feature though, so I'm willing to contribute to fixing this my self. But Id like pointers in knowing where to find the code relating to printing out file links. Like which repository.

from rust.

This seems low priority. I value this feature though, so I'm willing to contribute to fixing this my self. But Id like pointers in knowing where to find the code relating to printing out file links. Like which repository.

uh, rust-lang/rust?

from rust.

aiui doctests are actually extracted into a new file by librustdoc and then compiled, with no awareness of what their line/column was in the original file and thus no ability to offset them. you would have to probably poke at https://github.com/rust-lang/rust/blob/aec67e238d366c4c41373b272f19dd79ff5ec0f0/src/librustdoc/doctest.rs at minimum to address this.

( initially also said https://github.com/rust-lang/rust/blob/aec67e238d366c4c41373b272f19dd79ff5ec0f0/compiler/rustc_builtin_macros/src/source_util.rs but I think that's a red herring, now that I've reviewed the relevant assert! code. )

from rust.

Related:

• #79417
• #122941

from rust.

By offset I meant I could probably first figure out what line the doctest itself is in the source file, then take that line number and add to what ever the current runner outputs. Seems simple enough? Or are there other things I need to worry about. My IDE seems to be able to figure out where a doctest lies (RustRover) assuming it is using some rust compiler API.

from rust.

By offset I meant I could probably first figure out what line the doctest itself is in the source file, then take that line number and add to what ever the current runner outputs. Seems simple enough?

The output is from the assert inside the compiled binary.

from rust.

The runner doesn't know anything, it is only repeating this from the binary:

It gets the location from here:

This is generated by compiler magic, about... here?

But I believe the interesting code that actually determines the spans to output is here:

Ideally we'd somehow convince rustdoc to use the original source spans while compiling this.

from rust.

oh, goofier solution:

during extraction, insert sufficient newlines.

from rust.

That seems be a good idea

from rust.

oh, goofier solution:

during extraction, insert sufficient newlines.

Might not work if the test is sufficiently close to the top of the file, I think.

from rust.