Vxworks build error for current master branch. Need to update some source. about rust HOT 10 OPEN

The standard library denies all warnings in its build. One of the warnings the Rust compiler issues is "you added an unsafe {} block but you didn't need it".

from rust.

@biabbas

Why is Error and unused import in process_vxworks.rs as it is referenced twice in the same file.

Because it is both times referenced by the qualified io::Error form:

from rust.

For the unused_imports linting, the qualified form isn't considered to be equal to the unqualified form, and the import makes the unqualified form available.

from rust.

it seems originally @BaoshanPang was the maintainer of these targets.

from rust.

Why are there unsafe errors for unsafe blocks? If I add the whole fn as unsafe and remove unsafe blocks, I'm able to compile for vxworks.

from rust.

The standard library denies all warnings in its build. One of the warnings the Rust compiler issues is "you added an unsafe {} block but you didn't need it"

But for vxworks somehow these are not disabled. Is this because we only build the libraries for vxworks.

from rust.

Somehow it thinks libc::pwrite is not an unsafe extern "C" function...?

from rust.

Pushed commits to build nightly for vxworks. Current stable source 1.79.0 can be built after applying this patch.
1.79_stable.patch

from rust.

Update: After the previous rollup merge, most of the errors are fixed for VxWorks, except for libc references. I have a few doubts.

1. After a change to master rust libc repo, how long before the changes are reflected in the crates downloaded using cargo?
2. I Would like to contribute to the the rust. Can I add myself to libs review rotation?
3. What are the requirements to be a contributor?
4. How to get these changes to stable 1.80?
5. I build the compiler with command x build -i --target={vxworks_target} -j 10. The compiler build is 1.79.0-dev. I would like to remove dev from this.
   Thanks.

from rust.

Also in the previous pr, I wasn't able to add this file because clang tidy failed. I tried various methods to format the file vxworks.md this but still clang tidy check failed. ab90323

1. Used online tools to tab indent this.
2. Ran x.py fmt. (This did not seem to do anything.)

from rust.